wimbarelds / TimeCircles

jQuery plugin to show time since or time until a specific time
295 stars 149 forks source link

JSON validation error in bower.json #56

Closed herve-brun closed 10 years ago

herve-brun commented 10 years ago

Corrects a json validation error typo in bower.json. The last version of bower (1.3.7) can't use the file as is. My bad, sorry ...

wimbarelds commented 10 years ago

Hah, on my local machine Id actually removed that comma because my IDE failed to parse the JSON. Suppose I shouldve probably just included that. Thanks :)

herve-brun commented 10 years ago

ok ! You have installed bower then ? :) You want to register TimeCircles by yourself or would you still like me to do it ?

wimbarelds commented 10 years ago

Still don't have bower, but json is json. I use Netbeans, which gave an error on that comma.

Please, do register it for me.

A question though, is there any way to track downloads through bower?

herve-brun commented 10 years ago

I'm not sure but I see there's this page : http://stats.bower.io/ It seems to be just some kind of 'hall of fame' right now (Coming soon: more metrics, per-package API, badge service...). I didn't find a way to get the data for one particular package for example but maybe I'm just wrong ...

herve-brun commented 10 years ago

Oh and, by the way, could you re-tag 1.5.0 ? (if that is possible ?) Bower is using your git tag 1.5.0 (which holds the invalid json file) to get the source.

wimbarelds commented 10 years ago

Ah, I can't re-tag it on the same version number. I've had that problem a few times with the plugins.jquery.com file too.

Do you want me to re-tag to 1.5.1? I could also wait a few days- I made a lot of changes today so chances are something will have broken. Could wait for that before retagging, but could also just do that now.

herve-brun commented 10 years ago

OK for a 1.5.1. As it's 1:30 am (for me at least :) I will have to go to soon. So if you want we can do this in the next coming minutes or in a few days if you prefer to be sure of your changes.

wimbarelds commented 10 years ago

Did a 1.5.1 release just now

herve-brun commented 10 years ago

bower register timecircles https://github.com/wimbarelds/TimeCircles.git

bower convert Converted https://github.com/wimbarelds/TimeCircles.git to git://github.com/wimba relds/TimeCircles.git bower timecircles#* resolve git://github.com/wimbarelds/TimeCircles.git# bower timecircles#* download https://github.com/wimbarelds/TimeCircles/archive/1.5.1.tar.gz bower timecircles#* extract archive.tar.gz bower timecircles#\ resolved git://github.com/wimbarelds/TimeCircles.git#1.5.1 [?] Registering a package will make it installable via the registry (https://bower.herokuapp.com), continue? Yes bower timecircles register git://github.com/wimbarelds/TimeCircles.git

Package timecircles registered successfully! All valid semver tags on git://github.com/wimbarelds/TimeCircles.git will be available as versions. To publish a new version, just release a valid semver tag.

Run bower info timecircles to list the available versions.

herve-brun commented 10 years ago

Voilà !!! http://bower.io/search/?q=timecircles