wimdeblauwe / htmx-spring-boot

Spring Boot and Thymeleaf helpers for working with htmx
Apache License 2.0
496 stars 48 forks source link

@WebMvcTest needs META-INF configuration #77

Closed dsyer closed 12 months ago

dsyer commented 1 year ago

There is a org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureWebMvc.imports in this project so the tests work here, but it's not in the published jar files so users do not benefit from it. Since it's just a text file we could move it into src/main/resources and everyone would be happy?

wimdeblauwe commented 1 year ago

Great idea, I have done simliar in my other project error-handling-spring-boot-starter

xhaggi commented 1 year ago

@dsyer could you please explain why users benefit from it when no test classes are published in the jar files?

dsyer commented 1 year ago

Because they can use it in their own tests. I thought that was obvious.

xhaggi commented 1 year ago

Ah, of course, I hadn't thought of that.