Typing fixes - Githubissues

wimglenn / pytest-structlog

Structured logging assertions

MIT License

54 stars 6 forks source link

Typing fixes #27

Closed palfrey closed 7 months ago

palfrey commented 7 months ago

Fixes https://github.com/wimglenn/pytest-structlog/issues/15.

Also

Upgrades minimum Python to 3.7 and sets structlog requirement so we have typing support there.

wimglenn commented 7 months ago

Is there a point of type-hinting in the tests/*.py? IIUC users would only be interesting in typing of the plugin itself.

palfrey commented 7 months ago

Is there a point of type-hinting in the tests/*.py? IIUC users would only be interesting in typing of the plugin itself.

Main reason for that is to act as a test case for the "check this works when someone installs it" i.e. the "pip install without -e" case, which already caught errors in 3d88415306bfd7a2680bc03af98c591f2c1c3715. Also a little bit of personal preference for typing tests as well for better IDE support.