search

wimh / SparkleShare

SparkleShare is a file sharing and collaboration tool inspired by Dropbox.
http://www.sparkleshare.org/
GNU General Public License v3.0
39 stars 6 forks source link

More information in add remote folder #12

Closed kvaggelakos closed 12 years ago

kvaggelakos commented 12 years ago

This is my first contribution to a opensource project ever so please go easy on me!

I have redesigned the add remote folder screen. I have also added a function that replaces the picturebox with a groupbox containing the information needed.

I read in the TODO that this should be done, thats why I did it.

Any comments on this would be nice!

wimh commented 12 years ago

First of all thank you for your contribution. I have to try it before I can comment on it. I'll try it asap, but this whole month I have been busy with more urgent other things. But it looks like the coming weeks I have more time to spend on this and other open issues.

kvaggelakos commented 12 years ago

Thats great! Let me know when you have tried it out. Also i was thinking about setting the information strings in like a resource manager. Any suggestions on how this can be done? Dont really know if that is necessary though.

wimh commented 12 years ago

Regarding the information strings. The linux version is multilingual, see the po directory. If technically possible, the same files should be used for the windows version. It is a bit stupid to ask the translators to translate the same text twice. I have not verified exactly how this can be done. However I have found gettext-cs-utils which provides tools to do this. I think there are two basic ways to do this.

  1. use the .po files at runtime to get the correct translation
  2. convert the .po files at buildtime to for example .resx to integrate it easier in windows.

Until I know (or someone tells me) which way to go, I am not spending time on the resource manager, to avoid the risk of having to change everything later again.

But this is just my opinion and I am open for any discussions. If you or someone else provides a good solution, I am happy to merge it.

Wim

btw, if I merge this pull request, you can have your name added to the AUTHORS file. Please let me know if that's ok with you. (or add it to the pull request yourself).

kvaggelakos commented 12 years ago

Do we have any descirptive text for the alternatives? If we do not I can make some up. I do not know how to use po files though, but I think it is better that we stick to the ones used by the linux and mac project. I can look into this as well, whenever I have the time.

Have you tried this request out? What did you think the way of showing information? Is it good enough?

[EDIT] I changed my mind, I will add my name in the AUTHORS file when I feel like I have contributed enough!

hbons commented 12 years ago

@kozze89 could you provide some screenshots of your changes? I don't have Windows, but I wanted to redesign this part of the dialog anyway (also on Linux and Mac), so perhaps we can work on this :)

wimh commented 12 years ago

@kozze89, I did not try yet. I will try to look it next weekend.

wimh commented 12 years ago

@hbons, just for your information. The version I made of this dialog was a bit simpler than the linux version. It was not that easy to use different fontsizes, like in SparkleSetup.cs#L210. The standard windows controls do not support html. That's why I put it on my todo list.

(but I see the dialog has been changed for the current linux version - I will at least try to finish a merge this weekend)

kvaggelakos commented 12 years ago

@hbons I have uploaded two pics. Where as one is before you hover your mouse over the options and the other one is when you have your mouse on the different options. As you can see I added groupboxes to this, however I don't know if that's the way to go.

Images: http://imageshack.us/g/194/mouseoverp.png/

hbons commented 12 years ago

@kozze89 that's not bad, but it has a few issues too. But if @wimh wants to merge it that's good, as it's better than the previous one.

I've made a wireframe of my idea that should be more clear: https://github.com/hbons/SparkleShare-Design-Corner/blob/master/add-project-dialog.png

I'm going to work on this in the Linux and Mac version. It would be great if you could do this on Windows too :)

kvaggelakos commented 12 years ago

@hbons I have a lot to do at this time so I cant promise anything and I am not sure if I am capable of doing it. But I want to at least try! If I am having problems or not making any progress in reasonable time I will notify you.

@wimh, please let me know if you want to merge it! I will tear it down and redo it when you have made up your mind.

wimh commented 12 years ago

I have merged it, but I wont remove it from my todo list yet.

I have two remarks;

But it is better than it was, so I have no reason not to merge it.

(And I did not need to make my mind up, just needed to find time to try it out. My computer at home is running linux, I only start windows when I need)

kvaggelakos commented 12 years ago

Sounds good!

EDIT: About your points, I totally agree. If I fix this can you repull the request? Or how does it work? I was thinking that I should finish this part before I go on. Just so that we have a working feature.

EDIT: Found the information about the IRC server! :)

wimh commented 12 years ago

You can just commit the changes to your own repository. And let me know in case I did not see it. I can get it directly from there, a pull request is not really required.

And you can use separate branches if you work on different features.