wimh / SparkleShare

SparkleShare is a file sharing and collaboration tool inspired by Dropbox.
http://www.sparkleshare.org/
GNU General Public License v3.0
39 stars 6 forks source link

Own IRC Server #18

Closed rendered closed 12 years ago

rendered commented 12 years ago

I have tried using my own IRC server for the notifications.

I am now getting this:

dangerous channel, change the setting to access

When each of the remote folders join.

wimh commented 12 years ago

I confirm. Related change: https://github.com/hbons/SparkleShare/pull/368

I think this will fix it:

// Option to allow access to channel when no password is defined
try
{
    string option = SparkleConfig.DefaultConfig.GetConfigOption("allow_passwordless_join");
    this.allow_passwordless_join = option==null || Convert.ToBoolean (option);
}
catch (Exception) {
    this.allow_passwordless_join = true;
}

if (this.allow_passwordless_join) {
    SparkleHelpers.DebugInfo ("ListenerIrc", "Accessing a dangerous channel, change the setting to not access");
    this.client.RfcJoin (channel);
} else {
    SparkleHelpers.DebugInfo ("ListenerIrc", "Dangerous channel, change the setting to access");
    base.is_connecting = false;
    OnDisconnected ();
    throw new ConnectionException ("Dangerous channel, change the setting to access");
}
hbons commented 12 years ago

I fixed this in my branch, please have a look. :)

wimh commented 12 years ago

@rendered I have merged the upstream branch now. This should be fixed, if not, please reopen.