wimleers / homebridge-sma-home-manager

SMA Home Manager & Inverter plug-in for Homebridge
GNU General Public License v2.0
10 stars 2 forks source link

Inverted Surplus Calculation #6

Closed bodomenke closed 1 year ago

bodomenke commented 1 year ago

@wimleers First of all: Great work. Thanks!

It seems there is an issue with the calculation of surpluses or at least in the label of the surplus accessories: it is shown as <= instead of >=…

Pls see screenshot. 307A19DD-D288-436C-847C-4AB0AB960BC6

wimleers commented 1 year ago

Glad you like it!

Actually that <= is intentional: that's showing you the reason why it's currently off ("Nein" in German apparently!).

As soon as the energy signal turns on, it'll change 😊

The README says:

All energy signals have an On/Off status with a Reason to make it easy to understand why this energy signal is on or off.

Can you suggest how I should phrase that differently so that it's clear for the next person? πŸ™

wimleers commented 1 year ago

Oh wow, this was literally your first GitHub issue?! Welcome! πŸ˜„ 9EF9F798-7168-476D-AE3E-5A95B0E00126

bodomenke commented 1 year ago

Glad you like it!

Actually that <= is intentional: that's showing you the reason why it's currently off ("Nein" in German apparently!).

As soon as the energy signal turns on, it'll change 😊

The README says:

All energy signals have an On/Off status with a Reason to make it easy to understand why this energy signal is on or off.

Can you suggest how I should phrase that differently so that it's clear for the next person? πŸ™

I guess it is a matter of how one reads the Eve app screen and how one decodes logical expressions. πŸ˜‰

I do it like this:

Surplus <= X: Nein

-> results for me in logical consequence: Surplus > X: Ja

But I got you. The β€žNeinβ€œ relates to the name of the switch, which should ideally read like β€ž500+ Surplusβ€œ or so and the subline is simply the explanation, as you already stated.

So, I guess it is my reading failure. I will rename my switches and all is fine. 😊

bodomenke commented 1 year ago

Oh wow, this was literally your first GitHub issue?! Welcome! πŸ˜„

Yeah 😊😎 Thank you πŸ‘

wimleers commented 1 year ago

Alright! 😊

Feel free to let me know a rephrasing suggestion when you think of a better way to explain it!