search

wimmuskee / gengee

a Gentoo Github PR analysis tool
GNU General Public License v2.0
3 stars 0 forks source link

False positives with -o "references resolved bug" #7

Open juippis opened 4 years ago

juippis commented 4 years ago

Hey,

it's an awesome feature but there are few hiccups with it. For example, 

| 14628 |            net-p2p/retroshare: avoid broken doxygen-1.8.16            |  #70925 | PR references resolved bug |
| 14024 | dev-php/pecl-ast-1.0.5: Extension exposing PHP 7 abstract syntax tree | #703170 | PR references resolved bug |

Both of these linked bugs are in UNCONFIRMED state and to from what I can see, they were never in RESOLVED state.

Then something else to think about:

  1. There are few bugs that are resolved as WONTFIX (or OBSOLETE), kinda making the PR obsolete, while the fix may still be relevant.
  2. Some PRs are opened after a bug was RESOLVED, making it very relevant.

Now I truly don't know what's the best approach to those, but just informing you what I found.

wimmuskee commented 4 years ago

I tried to fix most of these issues by also checking the resolution (FIXED) when determining outdated (https://github.com/wimmuskee/gengee/commit/826fe70484ca0705ce3ed12ef492970257345056).

This way, we won't get false positives on other resolutions like OBSOLETE or DUPLICATE (bug 703170).

Ideally duplicates are resolved, but time has become scarce for me.

Just to understand, if a PR was opened after a bug was RESOLVED FIXED, the assumption is that a new bug condition has been found, and ideally the bug should be reopened (but the current state does not reflect this yet).