search

wimpysworld / desktopify

Convert Ubuntu Server for Raspberry Pi into a Desktop
https://www.youtube.com/watch?v=umtZuUJOU38
MIT License
518 stars 90 forks source link

Line 237 fails ShellCheck #68

Closed teward closed 2 years ago

teward commented 3 years ago

https://github.com/wimpysworld/desktopify/blob/50b72f96ea921618cf30b85b6ba147fc929a85cb/desktopify#L237

Per ShellCheck, this is an invalid implementation - instead you should be using a grep -q instead of an [-n ... ] comparison check.

This breaks all CI tests.

flexiondotorg commented 2 years ago

Fixed via #69