search

wimvanderbauwhede / RefactorF4Acc

An Automated Fortran Code Refactoring Tool to Facilitate Acceleration of Numerical Simulations
Other
57 stars 9 forks source link

Release tar ball #5

Closed rouson closed 5 years ago

rouson commented 5 years ago

Because I can't reopen issue #2, I'm submitting this new issue. My apologies for the delays. I'll make every effort to respond faster going forward. I'll attempt to give more a more complete description of what I think is required here.

On the review page, the Review checklist for @rouson section section contains the following item: "Version: Does the release version given match the GitHub release (v1.0.0)?". I interpret this as implying that

Please complete these steps and check the above boxes before closing this issue. I recommend using 3 digits for the version number to facilitate semantic versioning.

My original suggestion in issue #2 is a nice convenience and not a requirement, but for what it's worth, I still don't see how to find out the release version using the --version argument. My steps are below in case you'd like to support this. It would be great to be able to execute refactorF4acc.pl --version without having to define a configure file. Also, it would be nice to have refactorF4acc.pl --help return one-line descriptions of each possible argument.

$ git clone https://github.com/wimvanderbauwhede/RefactorF4Acc
Cloning into 'RefactorF4Acc'...
remote: Enumerating objects: 3582, done.
remote: Total 3582 (delta 0), reused 0 (delta 0), pack-reused 3582
Receiving objects: 100% (3582/3582), 25.69 MiB | 1.11 MiB/s, done.
Resolving deltas: 100% (2434/2434), done.
$ cd RefactorF4Acc/
$ export PERL5LIB="$PERL5LIB:${PWD}"
$ export PATH="$PATH:${PWD}/bin"  
$ refactorF4acc.pl --version
/home/rouson/RefactorF4Acc/bin/refactorF4acc.pl version 1.0.0 calling Getopt::Std::getopts (version 1.12 [paranoid]),
running under Perl version 5.26.1.
  [Now continuing due to backward compatibility and excessive paranoia.
   See 'perldoc Getopt::Std' about $Getopt::Std::STANDARD_HELP_VERSION.]
No default for toplevel subroutine (TOP) in rf4a.cfg, please specify the toplevel subroutine on command line
wimvanderbauwhede commented 5 years ago

I'm sorry, I used -V for the version flag. If you insist I will change the code to support long flags.

wimvanderbauwhede commented 5 years ago

OK, I've added --version and --help.