search

wimverstuyf / php-coda-parser

PHP parser for Belgian CODA banking files
GNU Lesser General Public License v3.0
41 stars 25 forks source link

Problem with Bpost CODA files #14

Open psampont opened 6 years ago

psampont commented 6 years ago

Hello,

In our case, the bank statements sent by BPost bank do not fully comply with the CODA standard. For the "account structure" field, in data record 1, at position 2. This field must take a value from 0 to 3. But in our account statements, this field is empty. So, the account information are'nt analysed.

It will be a good thing to provide final else in the function: account.addAccountInfo () in case of a empty $accountType.

wimverstuyf commented 6 years ago

Hi, Thank you for opening this issue. The value $accountType determines the account-information of whatever is behind this position. What information does this line have when the value is empty?

Could you provide an example? Or even better could you create a PR? I'm more than happy to accept a PR (accompanied by a unittest ;-) ) for this case.

psampont commented 6 years ago

What information does this line have when the value is empty?

In our case, empty value is equal to a "0" value.

It's difficult for me to send a P.R. because I work on a old version included in CiviBanking.

wimverstuyf commented 6 years ago

Hi, Thank you for the additional information.

I'll keep this issue open and make a change to the code the next time I'm working on to the library.

faissal6s commented 5 years ago

Hi, There is a problem with the statement's date, the parser returns the same value as the transaction date.