search

wimverstuyf / php-coda-parser

PHP parser for Belgian CODA banking files
GNU Lesser General Public License v3.0
42 stars 25 forks source link

Add client reference to transaction #28

Closed TSchuermans closed 6 months ago

TSchuermans commented 6 months ago

Could it be possible to add the original client reference to the transaction?

The reason I'm asking is because we store our own PO number in the client reference which makes it easier to link the coda transaction to an incoming invoice. This makes balancing our accounts/ledgers in our accounting software a lot easier.

wimverstuyf commented 6 months ago

Looks good. More than happy to approve this PR. Could you add (or update) at least one unit test that validates this new field? Then I can go ahead and merge this PR.

TSchuermans commented 6 months ago

@wimverstuyf Thanks! Added a test in e7de49e714e42eda32bcbb8ac6f139bdfd508364. I also took the liberty to add a composer shortcut for running tests btw. You can now run tests by executing: composer test

wimverstuyf commented 6 months ago

Looks great!

TSchuermans commented 6 months ago

@wimverstuyf could you also tag a release? Thanks!

wimverstuyf commented 6 months ago

Done!