search

win-acme / win-acme

A simple ACME client for Windows (for use with Let's Encrypt et al.)
https://www.win-acme.com/
Apache License 2.0
5.25k stars 813 forks source link

Exception when using IIS and IISFTP installers in a single renewal #2170

Closed NETvide closed 1 year ago

NETvide commented 2 years ago

Describe the bug Refreshing 1 of 2 certificates fails on v2.1.22.1289 (x64, ReleasePluggable) with the following error

(DependencyResolutionException) Unable to install certificate: Cannot choose between multiple constructors with equal length 4 on type 'PKISharp.WACS.Plugins.InstallationPlugins.IIS'. Select the constructor explicitly, with the UsingConstructor() configuration method, when the component is registered.

Regressing to v2.1.12.943 (x64, ReleasePluggable) works perfectly.

To Reproduce

  1. Pick menu options R
  2. See error

Expected behavior Certificates updated

Platform:

Additional context

WouterTinus commented 2 years ago

If you go the %programdata%\win-acme folder and examine the .renewal.json file there, what does the InstallationPluginOptions section look like?

NETvide commented 2 years ago

renewal.json, InstallationPluginOptions & History

"InstallationPluginOptions": [

{

  "Plugin": "ea6a5be3-f8de-4d27-a6bd-750b619b2ee2"

},

{

  "SiteId": 11040,

  "Plugin": "13058a79-5084-48af-b047-634e0ee222f4"

}

],

"History": [

{

  "Date": "2021-06-13T10:20:42.8817761Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "A3184B0B32EB67E8817D0FC0BF58B6D9A7FCF8C9"

  ],

  "ThumbprintSummary": "A3184B0B32EB67E8817D0FC0BF58B6D9A7FCF8C9",

  "ErrorMessages": []

},

{

  "Date": "2021-08-08T09:31:52.5762858Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "C570DC62A723B7AD2BBE94CFB1DD48F8A0DEC138"

  ],

  "ThumbprintSummary": "C570DC62A723B7AD2BBE94CFB1DD48F8A0DEC138",

  "ErrorMessages": []

},

{

  "Date": "2021-10-03T08:11:04.854154Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "19ACC857B8721BB7A51CEB5E4AAA0743E47F5197"

  ],

  "ThumbprintSummary": "19ACC857B8721BB7A51CEB5E4AAA0743E47F5197",

  "ErrorMessages": []

},

{

  "Date": "2021-11-27T10:33:10.5805603Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "38F8FB290EDFDA346D9090B7C21FEEEBC61220DD"

  ],

  "ThumbprintSummary": "38F8FB290EDFDA346D9090B7C21FEEEBC61220DD",

  "ErrorMessages": []

},

{

  "Date": "2022-01-22T09:46:12.9379945Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "142F4249DDBDCB22414F98AA04FB021A510215B0"

  ],

  "ThumbprintSummary": "142F4249DDBDCB22414F98AA04FB021A510215B0",

  "ErrorMessages": []

},

{

  "Date": "2022-03-18T10:05:34.2460723Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "508C71710CB3CDBBD3D3C35282719990AEFCE5B6"

  ],

  "ThumbprintSummary": "508C71710CB3CDBBD3D3C35282719990AEFCE5B6",

  "ErrorMessages": []

},

{

  "Date": "2022-05-13T09:17:17.4961014Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "F1AA7B6883F548EC1950A54F16E37BD2D78B675F"

  ],

  "ThumbprintSummary": "F1AA7B6883F548EC1950A54F16E37BD2D78B675F",

  "ErrorMessages": []

},

{

  "Date": "2022-07-08T08:55:32.4008127Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "0D828CCDB2A2C5E2607E53856E4544EA041B0BA8"

  ],

  "ThumbprintSummary": "0D828CCDB2A2C5E2607E53856E4544EA041B0BA8",

  "ErrorMessages": []

},

{

  "Date": "2022-07-14T10:11:39.3119498Z",

  "Abort": false,

  "Success": false,

  "Thumbprints": [

    "62F6308BA32249E7DD4D44071091A8D9CAAE46E6"

  ],

  "ThumbprintSummary": "62F6308BA32249E7DD4D44071091A8D9CAAE46E6",

  "ErrorMessages": [

    "Install failed: Cannot choose between multiple constructors with equal length 4 on type 'PKISharp.WACS.Plugins.InstallationPlugins.IIS'. Select the constructor explicitly, with the UsingConstructor() configuration method, when the component is registered."

  ]

},

{

  "Date": "2022-07-14T10:16:43.9799929Z",

  "Abort": false,

  "Success": false,

  "Thumbprints": [

    "62F6308BA32249E7DD4D44071091A8D9CAAE46E6"

  ],

  "ThumbprintSummary": "62F6308BA32249E7DD4D44071091A8D9CAAE46E6",

  "ErrorMessages": [

    "Install failed: Cannot choose between multiple constructors with equal length 4 on type 'PKISharp.WACS.Plugins.InstallationPlugins.IIS'. Select the constructor explicitly, with the UsingConstructor() configuration method, when the component is registered."

  ]

},

{

  "Date": "2022-07-14T10:22:00.4009196Z",

  "Abort": false,

 "Success": false,

  "Thumbprints": [

    "62F6308BA32249E7DD4D44071091A8D9CAAE46E6"

  ],

  "ThumbprintSummary": "62F6308BA32249E7DD4D44071091A8D9CAAE46E6",

  "ErrorMessages": [

    "Install failed: Cannot choose between multiple constructors with equal length 4 on type 'PKISharp.WACS.Plugins.InstallationPlugins.IIS'. Select the constructor explicitly, with the UsingConstructor() configuration method, when the component is registered."

  ]

},

{

  "Date": "2022-07-14T10:25:54.4481427Z",

  "Abort": false,

  "Success": true,

  "Thumbprints": [

    "C1BCA7DA8B1D75562747B676FE0F4E32F4F3BA44"

  ],

  "ThumbprintSummary": "C1BCA7DA8B1D75562747B676FE0F4E32F4F3BA44",

  "ErrorMessages": []

},

{

  "Date": "2022-07-14T10:30:48.300278Z",

  "ExpireDate": "2022-10-12T10:11:45+01:00",

  "Abort": false,

  "Success": false,

  "Thumbprints": [

    "62F6308BA32249E7DD4D44071091A8D9CAAE46E6"

  ],

  "ThumbprintSummary": "62F6308BA32249E7DD4D44071091A8D9CAAE46E6",

  "ErrorMessages": [

    "Install failed: Cannot choose between multiple constructors with equal length 4 on type 'PKISharp.WACS.Plugins.InstallationPlugins.IIS'. Select the constructor explicitly, with the UsingConstructor() configuration method, when the component is registered."

  ]

}

]

}

From: Wouter Tinus @.> Sent: 15 July 2022 22:19 To: win-acme/win-acme @.> Cc: John Constant @.>; Author @.> Subject: Re: [win-acme/win-acme] Certificate Refresh fails on v2.1.22.1289 with DependencyResolutionException (Issue #2170)

If you go the %programdata%\win-acme folder and examine the .renewal.json file there, what does the InstallationPluginOptions section look like?

— Reply to this email directly, view it on GitHub https://github.com/win-acme/win-acme/issues/2170#issuecomment-1185952174 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEGXQUX7MXRJ2LBCJO6UG3VUHIVNANCNFSM53SIMUZA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AAEGXQSRH7EYIPIYZ5Q5423VUHIVNA5CNFSM53SIMUZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI2YDDLQ.gif Message ID: @. @.> >

WouterTinus commented 2 years ago

Thanks for that input, I was able to reproduce and fix the issue. The fix in this build: https://ci.appveyor.com/project/WouterTinus/win-acme-s8t9q/builds/44190099/artifacts

NETvide commented 2 years ago

Yes all fixed and Thanks for creating a fantastic utility. John

From: Wouter Tinus @.> Sent: 16 July 2022 16:26 To: win-acme/win-acme @.> Cc: John Constant @.>; Author @.> Subject: Re: [win-acme/win-acme] Certificate Refresh fails on v2.1.22.1289 with DependencyResolutionException (Issue #2170)

Thanks for that input, I was able to reproduce and fix the issue. The fix in this build: https://ci.appveyor.com/project/WouterTinus/win-acme-s8t9q/builds/44190099/artifacts

— Reply to this email directly, view it on GitHub https://github.com/win-acme/win-acme/issues/2170#issuecomment-1186218408 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEGXQQQMII3URFY7N6BPPTVULIARANCNFSM53SIMUZA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AAEGXQRFH27L32WZEXQZ2TDVULIARA5CNFSM53SIMUZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI22EDKA.gif Message ID: @. @.> >

josundt commented 2 years ago

I'm also waiting for this bugfix. Is any date set for the 2.1.23 release? (I'm currently not using the dotnet global tool...)

WouterTinus commented 2 years ago

Should be out soon, but in the meantime you can grab the build linked earlier in this thread.

WouterTinus commented 1 year ago

Fixed in 2.1.23