search

win32ss / supermium-electron

Supermium-based Electron
https://electronjs.org
MIT License
78 stars 3 forks source link

Stable Release? #5

Open Alex313031 opened 6 months ago

Alex313031 commented 6 months ago

Preflight Checklist

Problem Description

Hi, I have quite a number of Electron apps that I maintain, some are forks, some are from scratch. Of particular importance is my fork of VSCode, Codium > https://github.com/Alex313031/codium currently the only up to date VSCode that works with Win7+. Most of my Electron apps are stuck on 22.3.27 because I don't want to give up Win7/8/8.1 compatibility and Ubuntu 16.04/Debian 8 compatibility.

This fork hasn't crashed in my testing, but there are two problems.

  1. It isn't built to stable like Supermium is (when you transitioned to stable Chromium, this repo didn't follow suit), and so wouldn't be suitable for production use with all my apps (or other people's apps).
  2. The layout of the repo is not conducive to building apps, i.e. you have to manually unpack everything and replace the electron binary, which also makes the icon the default electron one on windows.

Regarding No.2, that is definitely something I could help with, as I have compiler optimized versions of Electron 12, 13, and 22, and have set up repos to allow proper downloading and usage with things like gulp-electron, electron-builder, and electron-forge. Specifically, note how this is set up > https://github.com/Alex313031/electron-22/releases The tag names and names of the distribution packages must match the way they are laid out in the official repo, and for downloading it in an app, you must depend on something like this https://github.com/Alex313031/electron-releases-22 which is simply a clone of the upstream electron npm package, with a modified GET line which tells it to download from my repo instead of upstreams. If you do the work to make a stable supermium-electron release, I would be glad to help you with making the releases and a supermium-electron npm package, to facilitate people to actually use the fork in their workflows (or CI for example) to make production-ready, distributable Electron apps for Win NT 6.x

Proposed Solution

Make stable release, change names and takes in the releases to match upsteam's naming scheme, make an npm package to allow builders/packagers that consume electron to work with this fork.

Alternatives Considered

Download your release, and set up my own release repo and npm package with it, but this wouldn't resolve the need for a stable version, and wouldn't provide proper attribution to you since people might think I made the electron fork.

Additional Information

No response

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

Asmedian commented 2 months ago

Any chance we'll get regular electron releases at Supermium? In any form, as long as we understand that there will be regular fixes/updates. I would like to transfer my project from electron 22 to a modern one with win7 support, but due to possible problems that will not be fixed, I still don’t take the risk.