search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.5k stars 86 forks source link

More modern file picker dialog on XPSP3 #245

Closed JoachimHenze closed 9 months ago

JoachimHenze commented 10 months ago

Supermium Version 121.0.6167.81 Hotfix 32bit, on 32bit XPSP3.

Observed result When I open the file-picker-dialog (e.g. by clicking "upload file" in some JIRA bugtracker) Supermium presents me the following very oldschool dialog: image That dialog is compatible to Win3.11 and Win95 I guess, but is very inconveniently to use for the user.

Expected result Contrary WinXP and 2k3 do also offer the following dialog (iirc it is from comdlg32), that is used by default by Google Chrome v49 on XPSP3: image

Yes, it may me not be that backward compatible as the one you choose here, but it would be a much better choice for XPSP3. Iirc even Windows 2000 does have that dialog already.

Can we switch to the newer one for XPSP3 at least?

andika207 commented 10 months ago

When I open the file-picker-dialog (e.g. by clicking "upload file" in some JIRA bugtracker) Supermium presents me the following very oldschool dialog:

Agreed. I tried to upload a picture https://postimages.org/ and the legacy pickup dialog pops up

win32ss commented 10 months ago

I will add the newer UI for Windows 2000 and up.

mserafym commented 10 months ago

This old dialog from Win31 has in addition problems with displaying Unicode, long names, and when I try to upload an image to Github in a comment, some non-printable characters are poured into the text field, instead of loading the attachment normally... (Windows XP):

1) Trouble1

2) Trouble2

win32ss commented 10 months ago

I have made a change and it seems to have fixed the issue: image Although I think the "read-only" box does not belong there and I will probably remove it. Also need to clean up the file filter.

JoachimHenze commented 10 months ago

Hooray, first commit was https://github.com/win32ss/supermium/commit/9ab0b50fc03be933241a34a8bf96b9e99f7e0807 and the 2nd one was https://github.com/win32ss/supermium/commit/3374f0663ab4b58ee278524031b89e1a2e4abfb8

mserafym commented 10 months ago

I have made a change and it seems to have fixed the issue: image Although I think the "read-only" box does not belong there and I will probably remove it. Also need to clean up the file filter.

Thank's!

JoachimHenze commented 9 months ago

I do confirm that this bug was fixed to my satisfaction by Supermium 122.0.6261.85. It does now open the correct file-picker-dialog also on Windows XPSP3. Nevertheless I had to create a small follow-up-ticket of minor importance https://github.com/win32ss/supermium/issues/332