win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.42k stars 83 forks source link

live caption not working #297

Open Juesto opened 8 months ago

Juesto commented 8 months ago

supermium 121 hotfix on windows 7 sp1 x64 i have it enabled and the language downloaded but there's no reaction in playback other languages also do not work

win32ss commented 8 months ago

For the past few days I have been working on polishing Supermium 122, so I have only been able to check out this issue now.

The problem is that this feature seems to be non-functional even on generic Chromium 120 builds from the snapshot repository. There is no caption that appears there either (Supermium at least says it's unavailable).

I wonder if this feature is supposed to be only for Google Chrome but is poorly guarded unlike other Chrome-specific functionality?

win32ss commented 8 months ago

Although I couldn't get the caption to show up at all on Windows 10 last night, I tried on Supermium 122 on XP and determined that the guts of Live Caption are in a separate binary named SODA.dll. It is unable to load that DLL, likely because of missing functions.

progwrp will be reworked to support loading third-party binaries as opposed to just programs built with it. But as an advanced feature, it may be part of the Supermium Plus package.

note: the DLL does load on Windows 7, so nothing changes in that respect from earlier.

UPDATE:

I wonder if this feature is supposed to be only for Google Chrome but is poorly guarded unlike other Chrome-specific functionality?

Guess what: only Google Chrome is able to show live captions. Nothing else seems to share that functionality. I will try and see what happens when that DLL is loaded, but I'm not sure if I'll make much headway.

Juesto commented 8 months ago

chromium 109 has captioning working also the captions appearance settings are missing on earlier oses that dont have os support for captions

fac42 commented 3 weeks ago

Just tested this feature using the latest Supermium build (126.0.6478.254 R4) on Windows 10 Pro Build 19045 and unfortunately it doesn't seem to work. When I tested the same video with the a recent Wooly's Chromium build by Hibbiki (129.0.6668.101).

Here is the test video link (turn off the native video subtitles): https://www.youtube.com/watch?v=QzqGuFWE2Gs

Juesto commented 2 weeks ago

it has been established that SODA only works in google chrome not chromium and forks @fac42

fac42 commented 2 weeks ago

@Juesto I have it working in a Chromium build as I mentioned in my initial comment, so I'm not sure how they got it working? The link to their build is here: https://github.com/Hibbiki/chromium-win64/releases/download/v130.0.6723.70-r1356013/mini_installer.sync.exe

Edit: Links to other builds to try

win32ss commented 2 weeks ago

Back then, I wasn't aware of many "independent" Chromium forks with Google API keys, aside from Thorium and Supermium (they share the same keys). My other frame of reference was the official Chromium browser snapshots which do not have any API keys.

But I just tested both the sync and non-sync versions of the other browser. The non-sync version doesn't display the live captions while the sync version does. It seems their keys allow it and ours do not, possibly because they were generated before this feature was introduced (May 2021). And it also answers this question: https://github.com/brave/brave-browser/issues/15864#issuecomment-843419565, which I looked at back when this issue was opened.

Update: I just found that SODA (live caption) has its own API key. If my test is successful, I will expand the scope of the widevine patcher to soda.dll and XP so it can be used on those platforms as well.

Update II: Using the key, Live Caption is functional in Supermium. Now to make sure it works on 7 and XP.

Juesto commented 2 weeks ago

oh awesome, thanks!