search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.42k stars 83 forks source link

Supermium still enforces a choice on me on downloads, that it considers to be "unsafe" #423

Closed JoachimHenze closed 6 months ago

JoachimHenze commented 7 months ago

Supermium 122.0.6261.85 Hotfix (R2) 32bit https://github.com/win32ss/supermium/releases/tag/v122-hf on Windows XPSP3 32bit

A continuation of a ticket that I created earlier: https://github.com/win32ss/supermium/issues/247

test file is the same as which is used in https://github.com/win32ss/supermium/issues/415 http://218.94.103.156:8090/download/developer/vs/vs2008proedition90daytrialenux1435622.iso

I do have the following configured on Supermium: 1.) Chrome flag #insecure-download-warnings is set to disabled. Because I don't want stupid nagging warnings from the browser (when it downloads from http). It just shall start to download without nagging me. 2.) Chrome flag #disable-download-upload set to enabled, for the same reason: It shall just download without nagging me 3.) Chrome flag #download-bubble set to disabled, because I do prefer the download shelf over the bubble 4.) furthermore in the settings -> security I do have safeBrowsing feature turned off, because I don't want to be nagged, and I don't want my downloads to be sent to google neither: image 5.) I do use the cmd-line param --safebrowsing-disable-download-protection (hoping to make it stop whimpering)

Expected result: I don't want to be nagged with foolish questions like: image It should just start to download! I am ok with setting yet another cmdline param, or chrome-flag for that purpose (or fixing the existing #insecure-download-warnings to cover that case as well). No need to change the browsers default behavior. Let our grandmas be safe!

Observed result: Supermium still nags me with that foolish question for the case of the link above being http (which is not https): image That nonsense is inherited from the Google Chrome guys ofc.

win32ss commented 7 months ago

I was working on the --ungoogled-supermium switch and I decided to target safe browsing (although it doesn't seem to be even part of safe browsing!). It seems to work with some other flagged binaries like progwrp.dll but I will have to verify a little more. The downloading part of that switch can be integrated into --insecure-download-warnings as well.

JoachimHenze commented 7 months ago

The downloading part of that switch can be integrated into --insecure-download-warnings as well.

Sounds great!

JoachimHenze commented 7 months ago

https://github.com/win32ss/supermium/commit/fae39619269dfe9467da7fc741bfe44c0f37383a might be related and was committed after "Supermium 122.0.6261.85 Hotfix (R2)" was released already, so I would expect it to be integrated in its successor.

JoachimHenze commented 6 months ago

I tried to retest this ticket with "Supermium 122.0.6261.152 (R4)", but the website has changed meanwhile and now queries for user credentials (on all browsers) and I don't have the credentials. I therefore assume that the ticket was properly fixed by https://github.com/win32ss/supermium/commit/fae39619269dfe9467da7fc741bfe44c0f37383a and I would open a fresh issue if I ever would see that message again.