search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
1.95k stars 64 forks source link

Supermium v122 r4 missing 1px divider? #534

Open Darthagnon opened 2 months ago

Darthagnon commented 2 months ago

Describe the bug It's more noticeable when using a custom theme like Simple Silver, but the 1px divider line is now missing, so it's difficult to tell foreground and background tabs apart in Supermium v122 r4

To Reproduce Steps to reproduce the behavior:

  1. Install Supermium v122 r4
  2. (Optional) Install custom theme, e.g. Simple Silver
  3. Open several tabs
  4. The 1px divider along the top is gone, so background tabs blend into the browser's top chrome

Expected behavior 1px divider line should be present, as in previous releases?

Screenshots chrome_240503_54

Desktop (please complete the following information):

win32ss commented 2 months ago

I will tweak the tab drawing code to reintroduce this line to all inactive tabs.

Darthagnon commented 2 months ago

Thank you, win32!

Anotyx commented 2 months ago

Bez tytułu @win32ss I know this is kind of a long shot, but since you recreated 'compact mode' for both tabs and omnibox already, could you look into the bookmarks bar too? Currently, with compact UI and legacy omnibox it looks really out of place, taking up as much space as the entire toolbar + ~1/4 of one tab, Could you consider updating it in the future? Me personally would be happy even if it stayed the same but was shrinked a few pixels to match the rest. Thank you!

Anotyx commented 2 months ago

Bez tytułu Also, when you start TYPING in the url bar it'll use the new UI. And yes I know I shouldn't be writing about 2 other issues in someone else's issue, I'm new to github and not experienced enough to create my own, sorry.

Darthagnon commented 2 months ago

Bez tytułu @win32ss I know this is kind of a long shot, but since you recreated 'compact mode' for both tabs and omnibox already, could you look into the bookmarks bar too? Currently, with compact UI and legacy omnibox it looks really out of place, taking up as much space as the entire toolbar + ~1/4 of one tab, Could you consider updating it in the future? Me personally would be happy even if it stayed the same but was shrinked a few pixels to match the rest. Thank you!

I was thinking the Bookmarks Bar was looking a big chonky, thought it might have just been my eyes.

evanrutledge1 commented 2 months ago

Weird. I didn't see that with the bookmarks bar, like, ever. Probably because I was an OG user (I just created my Github acc though), and for a long time used the Chromium 69 - 119

TeleTimofeya commented 2 months ago

And how did you make such a realistic theme like in the old Google Chrome?

Darthagnon commented 2 months ago

And how did you make such a realistic theme like in the old Google Chrome?

er... you know how #377