search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
1.95k stars 64 forks source link

[Graphical] Address Bar Missing Its Outline Partially when Classic Theme and Compact UI is Enabled (Win 7) #572

Open FK2FAGHMS opened 2 months ago

FK2FAGHMS commented 2 months ago

Describe the bug If you enable compact UI in Supermium on a machine running Windows 7 with classic theme, you will get a bugged address bar that has its outlines missing at areas with no icons. To Reproduce Get a machine running Windows 7. Switch to classic theme. (Alternatively, use a High Contrast theme to get things easier (this will also enable Forced Colors, but I've disabled it in my setup).) Enable #compact-ui in about:flags. Expected behavior Address bar should look as same as before. Note that I've installed a custom theme to see if the issue goes away but it didn't have any effect.

Screenshots image

Desktop (please complete the following information):

Additional context There is no outline if you're using non-classic theme, so it will look normal. I don't think it's related to the version, simply, nobody had the combination that I've had, so no issues were reported until now. That's how it looks with Aero Theme: image

opzch commented 2 months ago

You may also want to enable #classic-omnibox and #classic-omnibox-border.

FK2FAGHMS commented 2 months ago

Not present in this version.

Kiki79250CoC commented 2 months ago

Not present in this version.

That's precisely why before opening a bug report, it is generally advised to check if the latest release available still have this issue or not, as no serious developer will waste their time for a bug that were probably already fixed in newer versions.

So for the moment, the only thing you have to do is to upgrade to v122-r4 and if the issue is still not fixed, then you can come back here and get the developer's attention. If the bug is already fixed, then you can close this issue.

FK2FAGHMS commented 2 months ago

I'll wait for a genuine response which would be from the developer themselves, as he would know if any changes were done to the stuff like this. Edit: I did the update anyway, just out of curiosity. As I expected, enabling #classic-omnibox-border didn't fix it, but enabling #classic-omnibox did the trick (note that it also changes the shape of omnibox). Now that I'm used to the "modern" omnibox shape, I'd still expect a fix for that. image Without classic omnibox but classic omnibox borders image With both classic omnibox and borders I'll guess I'll just keep using it like that since it resembles the classic UI better. I did just enable trapezoid tabs to see if it would fix that graphical bug, but meh. I think it looks better this way anyway. But still there is a bug, so this issue will be kept open (unless developer closes it themselves).

win32ss commented 2 months ago

I will make sure that the middle outline will be properly drawn in all cases with #compact-ui in future. This is a side effect of the split between #classic-omnibox and #classic-omnibox-border.