[Visual, Enhancement] Missing button state for Restore button

[XakerTwo]

Description When you have aero enabled, applied browser theme, browser window is maximized and restore button pressed it "did not pressing" and visually stay in hovered state. Seems that is an aero only issue, so reporting this to chromium/chrome is useless. It's minor UI bug so not urgent

To Reproduce

1. Apply any theme that has custom frame (say with id kbkgdmbcegbedgcjpekbineokpgpkikd)
2. Maximize browser window if not yet
3. Hover over Restore button
4. Press and hold it - visually button still not pressed
5. Check Close or Minimize button - it will pressing

Expected behavior It should behave like any other button here

Screenshots

Button in normal, hovered and pressed states, captured on VM with Supermium 122.0.6261.85 R2

No theme (system implementation)


With theme (browser implementation)


Minimize button with theme (for comparison)


Chrome 109 Metro and Aero chrome_100_percent.pak resources (exactly same in 200% and for Supermium)

 

Desktop:

• OS: Windows 7 SP1 x64
• Supermium: 122.0.6261.152 R6 x64

Additional context By default browser use the system implementation of window frame and Minimize, Maximize/Restore and Close buttons. But when apply theme, that defines frame color, browser switches to own implementation and there some resources for those buttons in chrome_100_percent.pak and chrome_200_percent.pak.

• for Metro like design there 4 states for each button (normal, hovered, pressed and disabled), except for Maximize button - it have 5 resources.
• for Aero like - 3(no disabled state), except for the Restore button - only have resources for two states: normal and hovered. Also next id is free, but not actually used (nothing change if i add it, so guess it missing not in resources but in code)

So when you press restore button there no visual change/feedback. I checked resources of Chrome 109 and same there - no resource for pressed state of Restore button and next id is free

[XakerTwo]

small update - seems issue happens due to the same hash for restore_hover.png and restore_pressed.png images, and on packing, one of the resource aliasing to other so only one image packed.

also seems that resource for the restore icon hover state is different even from minimize and maximize. But image format is a bit unusual - 8bit grayscale+alpha (16bit). Due to lack of tool that be able to save in same format, i can provide only 8bpp RGB+alpha (32bit). It's also supported and used by close button.

restore_hover.png restore_pressed.png

and it's looks like that (almost no difference on image but noticeable in action)


btw once i managed to unalias them to separate resources, fixing become even more unurgent, but now it's as simple for you as copy-paste without any further changes (aliasing is packager thing, once files becomes different, it should not aliase them).

[XakerTwo]

just reminder

Still actual Supermium: 124.0.6367.245 RC1