[Bug] Supermium taskbar icon broken (v122)

Darthagnon commented 1 month ago

Describe the bug The Supermium taskbar icon appears broken, but the icon file/group itself looks fine in Resource Hacker and also when it is being used for F12 Dev Tools.

Screenshots Left is Supermium Browser, right is undocked F12 Devtools. chrome.exe is open in Resource Hacker. explorer_240523_81

Desktop (please complete the following information):

OS: Win10 v1709 x64
Bitness of browser: Supermium v122r6

Additional context Possibly related: #541

Darthagnon commented 1 month ago

Huh, icon seems to have randomly fixed itself. Maybe unpinning and repinning to the taskbar did the trick.

XakerTwo commented 1 month ago

does not looks like app icon corruption, more like explorer icon cache jokes (again)

try standard actions - run admin cmd, copy all this lines and put into cmd (usually last CRLF not copied and last command not executed so there is exit)

taskkill /IM explorer.exe /F
ie4uinit.exe -show
del "%localAppData%\IconCache.db" /a
del "%localAppData%\Microsoft\Windows\Explorer" /q /f
start "" "C:\Windows\explorer.exe"
exit

it will restart explorer and delete icons and thumbnails caches cmd should not ask for anything, but may display some errors. If it break commands queue and you end up with no explorer - make sure the input is empty and no command await for your action, and put start "" "C:\Windows\explorer.exe" and hit enter

if icon did not change - then it's not an explorer cache, if icon corruption is different or it's back to normal - it's solved.

UPD: the issue you linked, has one nuance - the corrupted icon in profile folder. Check "%localAppData%\Supermium\User Data\Default\" - there should be one ico file named as Google Profile.ico.

Darthagnon commented 1 month ago

So I tried your suggestion, XakerTwo, after the issue appeared again. And the icon has trashed itself for the 3rd time, now. I guess this is an actual bug and not just icon cache corruption.

XakerTwo commented 1 month ago

~ did not have such issue, but i also customized supermium icon and it's contantly pinned so icon pulling from .lnk file will try to unpin and observe it

UPD: probably i caught it by tail IDR_MAINFRAME can be extracted from exe of supermium 122 R2 using Restorator, extraction from 122 R6 give me an error, while RH extract it without any error Looking at icon (group icon) i notice that while icon dimension assumed to be square they not - height for all icons is doubled (except for largest one, but probably it's just not visible). I also notice unusual data sizes. I'm sure that issue mostly in dimensions

If you wish i provide(later) two versions of fixed icons: height only, resaved with proper sizes. Also you may do it your self but take a note - probably editor, you will use, give you an error or the image plus overlapped data. In 2nd case you need to crop images by height first, then save. In 1st, or if you wish, you can read specs of ico and try to fix height by hands.

icon with overlapped data on invalid height

![bad_icon_read_rslt](https://github.com/win32ss/supermium/assets/13261533/d371f712-e619-496c-bc47-43330ea3962b)

Darthagnon commented 1 month ago

I reconstructed the icon using Axialis Icon Workshop. All the same sizes and formats as by default are there, but somehow the image has a smaller filesize. Replaced the original icon in chrome.exe with this fixed one using Resource Hacker, let's see how it works (so far, so good). Fixed.zip

XakerTwo commented 1 month ago

ico of size 256x256 is png, so Axialis may use better compression and/or OptiPNG rest stay bmp, but yes sizes after Axialis also expected/usual so icon is full and common vanilla

so waits for your results since i have no such issue all the day

Darthagnon commented 1 month ago

My fixed icon works perfectly so far. No corruption. The original icon has some sort of dodgy encoding going on.

XakerTwo commented 1 month ago

well, nice - you found an issue, we found a solution, @win32ss can apply it

there no any complex encoding except for the only correct ico in PNG format(256x256). BMP is just bottom-top pixels data in BGRA order. i not digged it much since my last message, but can guess few things

there a bug in ico encoder, that was used to create it, so height was doubled.
size, i found unusual, is probably weird size optimization by omitting 1st line trailing zero pixels and relying on/abusing fact, that reader implementation will be safe. But in windows explorer example, where all icons stored in cache in raw form one by one, it cause reading data of omitted pixels from next icon, plus double height also make it even worse. Probably in Win7- explorer abuse fact that icon is square and assign width to height, so only corner can suffer from size optimization.

Darthagnon commented 1 week ago

Can this issue be closed? Or has my fixed icon been used?

win32ss commented 1 week ago

Can this issue be closed? Or has my fixed icon been used?

I had multiple "fixed" icons at my disposal. Forgetting which one was which, I used another one. But then it appears to be stretched in some sizes as viewed on the file properties for chrome.exe on Windows XP, so I am now using your icon and I will credit it you for fixing in the release notes for the next version (which will incorporate the fixes for the recently reported 8.1 and XP bugs).

XakerTwo commented 5 days ago

hope you will credit both of us, since it was investigated by me

and about XP (noticed on SP3 x64) - in file associations settings(tab in Folder options) Supermium icon looks exactly as on Darthagnon's screens

win32ss / supermium

[Bug] Supermium taskbar icon broken (v122) #616