win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
1.84k stars 61 forks source link

Incognito theme has issues with transparency #625

Open Darthagnon opened 1 month ago

Darthagnon commented 1 month ago

Describe the bug I'm running Supermium on Windows 10 v1709 with Glass8.eu for glassy titlebars and the theme Simple Silver Aero. Incognito mode somehow had the theme applied and had illegible text on the NTP, so I switched on #incognito-brand-consistency-for-desktop, but now the background tabs have a strange transparency titlebar bg colour applied to them: chrome_240526_90

Other relevant flags I have enabled:

#incognito-brand-consistency-for-desktop
#disable-windows-10-custom-titlebar
#force-xp-theme
#custom-tab-shapes

Expected behavior I'm wondering if these background tabs are the default behaviour for Win10, but it doesn't fit very well with the custom tab shapes. Shouldn't they should be an unfocused gray, rather than the BG titlebar colour?

win32ss commented 1 month ago

It is default behaviour on Windows 10, based off previous behaviour. I'll probably add a switch to remove the influence of the system colours on the tabs and ultimately move towards having all colour values being user-customizable.