win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.22k stars 74 forks source link

[UI] No Tab Search button when theme applied #635

Open XakerTwo opened 4 months ago

XakerTwo commented 4 months ago

Description ~~Again themes involved and again those one with custom frame that lead chrome to use own implementation When no theme or simple one is applied there Tab Search button in frame caption, when theme with custom frame applied this button disappears~~ When Classic theme engaged by theme or forced by #force-xp-theme flag - the Tab Search button disappear from frame caption regardless of #remove-tabsearch-button

To Reproduce

  1. Reset theme if any and set #force-xp-theme flag to Disabled or Default and restart browser (to bypass #605)
  2. Note that there is a TabSearch button before minimize in window caption
  3. set #force-xp-theme to Enabled or apply any theme with custom frame (e.g. kbkgdmbcegbedgcjpekbineokpgpkikd)
  4. Now Tab Search button disappear

Expected behavior There is flag #remove-tabsearch-button, so Tab Search button presence should be controled by this flag.

Screenshots

Tab Search button absence ![tscb_absence](https://github.com/win32ss/supermium/assets/13261533/146d77cb-ac8d-4dda-a7a2-1262b431229e)

Desktop:

UPD: Tab Search completely unavailable under Windows XP via UI cuz browser use Classic theme by default. However it can be accessed via chrome://tab-search.top-chrome

P.S. Don't know how it behaves in current Chrome, but in Chrome 109 TabSearch behaves as expected and presented when custom frame engaged.

XakerTwo commented 2 months ago

just reminder

Still actual Supermium: 124.0.6367.245 RC1