search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
1.83k stars 60 forks source link

M124 rebase questions #651

Open Alex313031 opened 3 weeks ago

Alex313031 commented 3 weeks ago

Hi @win32ss. I would like to continue to make Thorium builds for Win7+ that omit progwrp entirely (using that only for XP/Vista).

If I rebase my current M122 patches to M124 manually (i.e. fixing line numbers after using git apply --reject), and just port features that you add to M124 as needed, will that work?

If not, would searching for PrefetchVirtualMemory, GetFirmwareType, GetDpiForMonitor and GetUserDpiAwareness in the M122 patches, and re-adding the code blocks related to them to the M124 version work?

If not that, then would you be willing to take the time to show me where specifically you have removed code (to be delegated to progwrp instead), so that I can re-add it back.

win32ss commented 3 weeks ago

Yes, all uses of those functions, and also the WinRT string/Ro API workarounds (WindowsCreateString, WindowsDeleteString, RoGetActivationFactory etc.) which were also removed, as well as one ProcessPrng workaround, are present in the 122 patches.

ihidao commented 3 weeks ago

Personally I think updated the core version isn't important, working stable is the most important