search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
1.83k stars 60 forks source link

Update Skia repo and look at PR. #660

Open Alex313031 opened 2 weeks ago

Alex313031 commented 2 weeks ago

Hi again, @win32ss I noticed that you updated the Skia third_party submodule. Please make the same changes and file a PR (or directly commit since you have access), at the https://github.com/Alex313031/skia-supermium repo.

In the future, you should make commits to that repo, and then just update the submodule revision in Supermium, instead of updating file locally in the Supermium repo, because now there is a diversion between the contents of the submodule's upstream and the contents of the directory in the Supermium repo.

Second, can you look at my PR related to fixing the omnibox outline when compact-ui is enabled > https://github.com/win32ss/supermium/pull/652

Also tagging https://github.com/xeoncross

win32ss commented 2 weeks ago

Yes, I will be sure to correct the other repo in the future, although the rebasing of main Supermium causes issues with the references to the submodules.

win32ss commented 2 weeks ago

Unfortunately I am having issues updating the main repositories on your accounts (and can't receive access tokens for them); a non-forced push/PR is not possible because of the nature of significant differences in revisions which would result in an excessive quantity of conflicts.

Alex313031 commented 1 week ago

I can update them to the proper revisions of Skia & PDfium, then you can file a PR with the updates to those two files.