search

win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.17k stars 72 forks source link

Supermium version number mismatch. #810

Open mina354 opened 3 weeks ago

mina354 commented 3 weeks ago

Describe the bug Supermium version displayed in the About page is different than the one displayed in Programs and Features.

To Reproduce Steps to reproduce the behavior:

  1. Open Supermium.
  2. Click on the hamburger menu, then click About Supermium.
  3. Open Control Panel, then go to Programs and Features
  4. Compare the version displayed in About Supermium window, and the version displayed in Programs and Features. There's a mismatch.

Expected behavior Both versions become the same.

Screenshots image image

Desktop (please complete the following information): OS: Windows 7 SP1 x64 (but it happens under any supported OS)

Vangelis66 commented 3 weeks ago

Both the x86 and x64 installers (initially) present on:

https://github.com/win32ss/supermium/releases/tag/v124-r2

have been updated/re-uploaded some 6.5 hr ago (as I type this); do the new installers exhibit the same bug? Disclaimer: I only use "portable" Sm installations, won't try a system installation here via the installer - apologies :smile: ...

mina354 commented 3 weeks ago

do the new installers exhibit the same bug?

Yes, they do.

Vangelis66 commented 3 weeks ago

Yes, they do

Thanks for the report :+1: ; it was much later I discovered the Supermium-124-r2 installers were, in fact, updated to incorporate a fixed fonts file, as per this :wink: ; sorry for the trouble caused :smile: ...

mina354 commented 2 weeks ago

sorry for the trouble caused 😄 ...

Well, no worries, my bug report is about something minor, but it would be great if @win32ss fixes it anyway.

kda2495 commented 1 week ago

Doesn't fixed in latest 126 release.

mina354 commented 5 days ago

Doesn't fixed in latest 126 release.

Yeah, I realize that too.

Vangelis66 commented 3 days ago

(Isn't) fixed in latest 126 release.

... I believe the root cause of this bug is the code below:

https://github.com/win32ss/supermium-installer/blob/987167d54c83d8dc2986ae4fd69f1ff73835e48d/supermium_installer_v3/supermium_installer_v3/supermium_installer_v3.cpp#L269

It still references 122.0.6261.152, while this value should be updated before compilation with whatever Supermium version (126.0.6478.249 being the current) the installer is about to bundle :wink: ...