win32ss / supermium

Chromium fork for Windows XP/2003 and up
https://win32subsystem.live/supermium/
BSD 3-Clause "New" or "Revised" License
2.46k stars 85 forks source link

Revert HTTPS and "Extensions" icons to the previous ones #873

Open Daniel7689 opened 2 months ago

Daniel7689 commented 2 months ago

I believe that reverting back the "Extensions" puzzle icon and the HTTPS lock icon will make the experience more akin to the one seen in 124

Vangelis66 commented 2 months ago

I believe that reverting back the "Extensions" puzzle icon

... There's a chrome://flags pref that is supposed to do just that in Sm-v126-r1:

ExtMB

... but it currently DOES NOTHING (with regards to the button) :sob: ; FWIW, this flag works as intended in Sm-v124-r2; the Default setting is "Disabled", so you get the "older" Extension Manager/Button; set it to "Enabled", relaunch and you'll get the redesigned Extension Manager/Button (identical to the current in Sm-v126-r1) ...

oleedd commented 2 months ago

It doesn't do nothing. It allows extensions to work on chrome://... pages and Chrome Web Store.

Vangelis66 commented 2 months ago

It allows extensions to work on chrome://... pages

Isn't chrome://flags/#extensions-on-chrome-urls the one for that? :wink:

oleedd commented 2 months ago

They both do the same for me. Weird. But the previous one requires "Disabled" to enable unlike this one.

win32ss commented 2 months ago

The old extension icon has returned in the latest version. But the old HTTPS icon should still be available in either version as the codepath is still there to use the old one.

Daniel7689 commented 2 months ago

The "Extensions" icon has reverted back to the old one in the latest release for me, but the HTTPS icon has remained the same after disabling Refresh, am I doing something wrong?

https
XakerTwo commented 2 months ago

not sure, but most likely chrome changed this control/button to reflect common use case - accessing site settings(btw icon is not updated - its style differ from ugly one). httpS now is common instead of http_, and when last is used, or something wrong with certificate - a warning will be displayed.

p.s. i even agree with this change. waiting for new button when quic become standard(not behind flag) :rofl:

Vangelis66 commented 2 months ago

@win32ss wrote:

The old extension icon has returned in the latest version.

... However, the "new" extension icon is STILL there (in the omnibox) when an extension tab is being loaded:

Sm-v126-r3:

126

Sm-v124-r2:

124

@XakerTwo wrote:

but most likely chrome changed this control/button to reflect common use case

... Google have deprecated the padlock icon in favour of the "tune" icon with M117 (stable), released a year ago:

https://blog.chromium.org/2023/05/an-update-on-lock-icon.html

Supposedly, there's no way one could get the padlock back in Chrome 117+ :

https://support.google.com/chrome/thread/255209933/get-old-chrome-lock-icon-back

but the padlock icon is still there in Sm-121/122/124, gone AWOL in Sm-126 :disappointed: ; while the maintainer claims:

the codepath is still there to use the old one.

obviously something turned awry during the rebase from 124 to 126 :wink: ; all this is, of course, nitpicking, we have an M126-based browser compatible with XP to 8.1 :tada: , but since this is an LTS/ESR Supermium release, fixing the "nitpicking" shouldn't be considered a 'luxury" :smile: ...

Daniel7689 commented 2 months ago

Supposedly, there's no way one could get the padlock back in Chrome 117+

You can't get the old icon for Extensions in 126 either but win32ss could do it so (besides Supermium 124 had the old padlock icon)

However, the "new" extension icon is STILL there (in the omnibox) when an extension tab is being loaded

I didn't notice that one, thanks

XakerTwo commented 2 months ago

+1 for omnibox - didn't notice that one

but even more surprise is that no one notice this ![image](https://github.com/user-attachments/assets/1b220437-7f8f-4116-9c92-2c0be42dcb06)

however i know where and how to modify last one, probably similar works for omnibox(and possibly same file, but debug native ui is kinda weird). try it a bit later...

for info it's page templates and iron-icons libs, that is includes svgs codes and gzipped. each lib/template is not a set of separate files - they are huge bundles
XakerTwo commented 2 months ago

not check all files, but found few - they are in negative space and initially may not be visible

.pak idx (v126 only) defs list idx def id possible usage link to src
18791 4 #my_extensions omnibox chrome/browser/resources/extensions/icons.html
22373 4 #my_extensions extensions page chrome/browser/resources/settings/icons.html
22373 5 #extension settings page ??? possibly aliased
23078 0 #extension-outline ??? chrome/browser/resources/signin/icons.html
spoiler of the hate ![to-hate](https://github.com/user-attachments/assets/ff1f6565-c127-4ee5-8fa7-3257171c114a)

will try to modify it later and post result if successed

Darthagnon commented 3 weeks ago

The Share icon is bugged and displays the new Chromium one in Supermium 126 R4: supermium 126 R4 icon bug

For reference, here is the correct icon in Supermium v122: chrome_241029_172

Vangelis66 commented 3 weeks ago

@Darthagnon

A bucketload of the "redesigned" icons, associated with CR23, have infiltrated the GUI of Sm-v126, even when the flags/settings/prefs to disable all traces of CR23 have been meticulously set :angry: ; I have the "share" button disabled myself (chrome://flags/#disable-sharing-hub), so not an issue for me, but the CR23 password-manager button inside my "classic" omnibox is a real eyesore for me:

126-mc

This button appears to notify you you have loaded a site for which stored account credentials are available (when the browser is set to NOT automatically sign you in) ...

Same button in Sm-v124 and earlier:

124-mc