search

winapps-org / winapps

The winapps main project, forked from https://github.com/Fmstrat/winapps/
Other
995 stars 43 forks source link

System icon support #109

Open Alchemi1963 opened 4 months ago

Alchemi1963 commented 4 months ago

I noticed that the install script favours system icons vs the present .svg files. However, I didn't have the icons installed myself.

Eventually I edited the script to use the svg instead. Maybe a check for the system icon can be added or let the user decide?

Alchemi1963 commented 4 months ago

Why was legacy added? I am not using legacy winapps...

jrevillard commented 4 months ago

legacy means the bash script.... seems that a Go version is under preparation ;)

oskardotglobal commented 4 months ago

*Rust, but yes

oskardotglobal commented 4 months ago

Legacy refers to the shell script version, which as you saw is kind of hard to maintain

NaniNoni commented 1 month ago

Is the rewrite still happening? The rewrite branch hasn't been touched in quite a while (9 months).

LDprg commented 1 month ago

@NaniNoni Yeah I have some unmerged changes on my fork, but I am currently very busy.

It is still beeing worked on. See #195

It will take some time until I get work on this again, but contributions are welcomed.

NaniNoni commented 1 month ago

No problem. I'm happy to help in any way that I can. I created FFI bindings to freerdp3 as that seems a better solution to using external processes everywhere: https://github.com/NaniNoni/freerdp-sys. I'm currently rewriting the winapps installer in Rust, as it's an independent component.