winapps-org / winapps

The winapps main project, forked from https://github.com/Fmstrat/winapps/
Other
998 stars 45 forks source link

installer.sh: line 140: grep -l -d skip: command not found #110

Closed Alchemi1963 closed 2 months ago

Alchemi1963 commented 4 months ago

Quite simply the title to be honest. I tried fixing this but couldn't find how since I don't entirely understand how !/usr/bin/env bash works.

Yes, I do have grep installed and I'm able to invoke it on my own.

Would you like to install for the current user or the whole system? User Removing any old configurations... Removing /home/melody/.local/share/applications/excel-o365.desktop... Finished. Removing /home/melody/.local/share/applications/explorer.desktop... Finished. Removing /home/melody/.local/share/applications/powerpoint-o365.desktop... Finished. Removing /home/melody/.local/share/applications/windows.desktop... Finished. Removing /home/melody/.local/share/applications/word-o365.desktop... Finished. Removing /home/melody/.local/bin/excel-o365... Finished. Removing /home/melody/.local/bin/explorer... Finished. Removing /home/melody/.local/bin/powerpoint-o365... Finished. Removing /home/melody/.local/bin/windows... Finished. Removing /home/melody/.local/bin/word-o365... Finished. Installing... Checking for installed apps in RDP machine (this may take a while)... Finished. Configuring Windows... Finished. installer.sh: line 140: grep -l -d skip: command not found ? How would you like to handle WinApps pre-configured applications? If any web browser is set-up, may be configured as default browser. (Use arrow keys) ❯ Set up all detected pre-configured applications Select which pre-configured applications to set up Do not set up any pre-configured applications

oskardotglobal commented 4 months ago

What OS are you running? It might be due to not running GNU grep?

jrevillard commented 4 months ago

I have the same on ubuntu 24.04

oskardotglobal commented 3 months ago

I feel like the fix mentioned in https://github.com/winapps-org/winapps/pull/108#discussion_r1632237661 might fix this

LDprg commented 2 months ago

@jrevillard @Alchemi1963 is this fixed with #139?

KernelGhost commented 2 months ago

@LDprg IIRC, I independently identified and corrected this issue in that PR.

KernelGhost commented 2 months ago

This issue should be able to be closed now. @Alchemi1963, would this be alright with you?