winapps-org / winapps

The winapps main project, forked from https://github.com/Fmstrat/winapps/
Other
998 stars 45 forks source link

Auto install script for docker/dockur/winapps with 2 network options (DHCP LAN + macvlan & host network) #182

Closed itiligent closed 3 weeks ago

itiligent commented 2 months ago

This script offers two Docker deployment options for running WinApps on Docker:

Option 1: [Easy] Deploys a Windows container with Dockur's default network settings

2. Option 2: [Advanced] Deploys a Windows container with macvlan networking

(Note: Script will auto install flatpak version of FreeRDP3 if a distro version is not available)

Script Instructions

  1. Run the script (without root permissions) & answer the script prompts to customize your build
  2. Follow the Windows install via VNC http://127.0.0.1:8006 or http://x.x.x.x:8006
  3. Restart Windows via the VNC console when the installation is complete
  4. Refresh Docker group permissions by running newgrp docker
  5. Test rdp from Linux by running ~/test-rdp.sh (this test script is created at install to suit the individual build settings)
  6. Install your preferred Windows applications as needed via RDP or VNC
  7. Run ~/winapps/installer.sh to install WinApps

More about macvlans:

The script is curently Debian/Ubuntu focused but can be used as a framework for other distros

itiligent commented 2 months ago

I made a final change to add a sound on/off prompt menu and simplified install instructions as a reboot seems best to avoid group permissions not always refreshing after docker is added via one continuous script.

oskardotglobal commented 2 months ago

I don't know about this one. The script makes a lot of assumptions and there is no documentation for it. For this to be merged the according installation documentation would have to be updated (but only for Debian-based distros).

itiligent commented 2 months ago

Firstly, this is a great project which is why I'd like to help it towards user friendliness & made more accessible for less technical folk, especially with the momentum that is building for ditching Windows as much as possible.

Regarding documentation, the script is a actually a coalescence of the very minimal amount of installation documentation I've been able to uncover. Another view (and a key part of my intent for submitting it) might be that reverse engineering it (its all quite clearly commented) would help produce a much more comprehensive set of real world install instrutions than exists anywere because in writing it I uncovered many gaps in the current docs that had to be worked though.

Could you please explain what documetation would be needed? Perhaps I could help? At a minimum this script could perhpas be viewed as the quantum of actual verified install steps to build the WinApps recommended environment?

Regarding script assumptions, I dont quite understanfd what you mean there. There are virtually no assumprions contained (as far as I can tell) and the user is guided through every key decision point I've uncovered in my own use of WinApps.. Could you please give some examples of assumptions and perhaps I could address those?

Regarding Debian based: perhaps this is what you mean by assumptions? I've put this install flow together as a kind of orderly install approach with a view that it could be expanded to other mainstream distros in the same way as I've smoothed out Docker's repo awkwardess of installation docs between Debian distros.

Happy to help!

LDprg commented 2 months ago

I feel like we shouldn't merge an debian only install script.

It should at least support debian, arch and fedora distros. This shouldn't be too much of a problem to implement and still avoid alot of confusion.

All in all the script seems very good, just some refinements missing.

I will make a proper review this weekend.

itiligent commented 2 months ago

Thanks for the feedback. Take your time and play with it and get a feel for it and what I've tried to achieve through it. More eyes will always help find the things I might not have thought of.

itiligent commented 2 months ago

Ok so I've done a bunch of work on this today.

My preference is to gather all the feedback on this debian version, and once everyone is happy with it, then I can look to expanding it to Fedora and Arch

itiligent commented 1 month ago

Just an update on my progress:

In my spare time I've done a bunch of work on tidying this concept up into something more refined and substantive eg On the WinApps side:

I'll have something ready in a few weeks. I expect

oskardotglobal commented 1 month ago

Thanks for the great work, @itiligent. We'll properly review this once you're ready

itiligent commented 3 weeks ago

Closing as I have progressed a much more refined install script version, and I will re-submit again soon.