search

winapps-org / winapps

The winapps main project, forked from https://github.com/Fmstrat/winapps/
Other
998 stars 45 forks source link

Precommit for legacy #98

Closed LDprg closed 4 months ago

LDprg commented 4 months ago

This is still wip and will need extensive testing when ready.

Since a there is a lot of formatting and manual fixing.

oskardotglobal commented 4 months ago

Yeah, we should definitely add shellcheck to our CI pipeline

oskardotglobal commented 4 months ago

pre-commit.ci autofix

LDprg commented 4 months ago

This is basically ready for early review and testing. Note that I DIDN'T TEST THIS, so it shouldn't be right up merged until testing install and running winapps completely

LDprg commented 4 months ago

Btw for testing I can really recommend using distrobox. (I know docker in docker is kinda strange but it works). It allows us to create a clean environment and test different distros without installing a vm for like 20 minutes.

oskardotglobal commented 4 months ago

Ok I'm having quite a bit of trouble getting winapps to work; it just refuses on my Nix machine The problem is that both the domain and the password have to be empty in my case and due to shell escaping the command winapps runs becomes

xfreerdp /p: /d: /u:Docker /scale:100 +auto-reconnect +home-drive -wallpaper +dynamic-resolution +span /app:program:explorer.exe /v:127.0.0.1

instead of

xfreerdp /p:"" /d:"" /u:Docker /scale:100 +auto-reconnect +home-drive -wallpaper +dynamic-resolution +span /app:program:explorer.exe /v:127.0.0.1

which works completely fine

oskardotglobal commented 4 months ago

Any suggestions?

oskardotglobal commented 4 months ago

I've also found a fix for my above problem & included the automatic installation of the reg file in this PR too

LDprg commented 4 months ago

@oskardotglobal can you update the docs accordingly?

oskardotglobal commented 4 months ago

Yeah, sure

oskardotglobal commented 4 months ago

.. Why does pre-commit remove the double spaces after lines They represent line breaks in Markdown

oskardotglobal commented 4 months ago

pre-commit.ci autofix

LDprg commented 4 months ago

.. Why does pre-commit remove the double spaces after lines They represent line breaks in Markdown

Propably some tab/line ending fixing precommit hook.

CiRiX- commented 4 months ago

What about this issue here? https://github.com/winapps-org/winapps/issues/91

The newer freerdp releases wont start apps.

oskardotglobal commented 4 months ago

@CiRiX- That seems like an issue with the user's specific version or with the changed syntax of the /app argument I don't wanna be that guy, but it seems like a skill issue; I'm running freerdp 3.5.1 on my Nix machine and it works just fine

LDprg commented 4 months ago

@oskardotglobal we might add a switch for the /app syntax depending on the freerdp version?

This would work around some package manager not providing any freerdp 3 packages and user confusion.

Or we ship a working freerdp v3 executable with winapps.

oskardotglobal commented 4 months ago

I think shipping a binary would be a good approach, but that would require the binary to not be linked against OS libraries since otherwise you would have to install a bunch of dependencies

CiRiX- commented 4 months ago

@oskardotglobal Don't worry, you are probably right :wink: I am not super experienced with Linux, and i'm not a programmer.

I think it should be more user friendly, so shipping a working version like @LDprg said would be a good idea i guess.

AkechiShiro commented 4 months ago

Maybe we'd need to work a wrapper for Freerdp v3 (in Bash maybe, that simplifies usage) ?