Closed mgedmin closed 2 years ago
Sadly, I can't repro this:
On cloning the repo, the file in question is hidden in a zip file:
And the unzip
tool which comes with macOS refuses to open it. 😢
Do you know the full path (the raw bytes of it) that has the invalid sequence? I could try to fix this blindly, but I'd like to test it with a real test case before I do.
On cloning the repo, the file in question is hidden in a zip file:
Oh, interesting! It must've been extracted while running the test suite. A quick git clean -dfx
and I can use command-t again!
So, from what I've heard about MacOS, its filesystem requires all filenames to be valid UTF-8 (and normalizes them into the NFD form, IIRC). I don't think it's possible for you to test it on your local system without using something like a Docker image or a Vagrant VM running Linux.
If you need an exact byte sequence, here's one that is enough to trigger the error in an empty directory:
but, again, I'm on Linux. I would expect the Python command that creates the file to fail on Mac OS.
Given the big rewrite for v6.0.x, I'm closing all older issues as there is unlikely to be anything significant happening on the 5-x-devel
branch from here on[^patches]. Feedback issue for 6.0.x is here:
[^patches]: Patches and PRs would be welcome, but my personal efforts are going to be directed towards main
.
I'm trying to work on linkchecker and I get the following error, most likely because there's a file in the test scaffolding with a non-UTF-8 filename:
To reproduce:
The bad file is in
tests/checker/data/dir/
.I'm fine with Command-T being unable to open or even list this file, but denying me access to the rest of the tree is a bit inconvenient.