wincent / command-t

⌨️ Fast file navigation for Neovim and Vim
BSD 2-Clause "Simplified" License
2.74k stars 317 forks source link

Enable CI via GH actions #377

Closed voxik closed 3 years ago

voxik commented 3 years ago

Hm, not sure if it can run right from the first PR :/

wincent commented 3 years ago

Perms are very loose:

Screenshot 2021-03-04 -193330-3SkGrMdq@2x

So we might have to fiddle to get this working. On other GitHub actions I've made I've used triggers with explicitly branches like this:

on:
    push:
        branches: [master]
    pull_request:
        branches: [master]

not sure if it is that sensitive to the format though.

voxik commented 3 years ago

I think I'll start to play with this in my fork and come back once I'll be smarter ;)

wincent commented 3 years ago

It's running now: https://github.com/wincent/command-t/commit/73a6acaf77d9d1b847635f3f68e9f6aaa9f31c70

wincent commented 3 years ago

And looks like with a bit of tweaking it will work: https://github.com/wincent/command-t/runs/2033753938

My favored technique here is just to push repeatedly making psuedo-random changes until it works.

wincent commented 3 years ago

I reckon this line is truncated:

https://github.com/wincent/command-t/blob/73a6acaf77d9d1b847635f3f68e9f6aaa9f31c70/.github/workflows/tests.yaml#L12

And if we just append the right bits to it it will work.

voxik commented 3 years ago

Ah, thx ... I messed up you commit again, I'll fix it shortly

voxik commented 3 years ago

Wow, it is passing. That was smoother then I thought.

wincent commented 3 years ago

Woot! Thanks.

voxik commented 3 years ago

Actually, the Rake could be used instead the custom build steps. But that could be enhanced once this is merged.