search

wincent / command-t

⌨️ Fast file navigation for Neovim and Vim
BSD 2-Clause "Simplified" License
2.74k stars 317 forks source link

[Question] why does RubyGems version of this package contains '../..' in the gem data path? #387

Closed mensfeld closed 2 years ago

mensfeld commented 2 years ago

Isn't that a mistake?

Please see the picture below: Zrzut ekranu z 2022-01-27 12-46-42

when unpacking this lib I get tar: Error is not recoverable: exiting now due to:

tar: Removing leading `../../' from member names
tar: ../../Gemfile: Member name contains '..'
tar: ../../LICENSE: Member name contains '..'
tar: ../../README.md: Member name contains '..'
tar: ../../Rakefile: Member name contains '..'
tar: ../../doc/.gitignore: Member name contains '..'
tar: ../../doc/command-t.txt: Member name contains '..'
wincent commented 2 years ago

It's quite possible that it's been broken like that for a long time[^hypothesis] — almost nobody uses the gem itself, instead just installing Command-T as a Vim plug-in (by pointing a plug-in manager at the repository).

[^hypothesis]: I'm suspicious of commit 8ec8f73b4cb071e63d5a0a6ef58258c9e03fbe93 ("Move Command-T files deeper", May 23, 2016) at which point the command-t.gemspec file moved down two layers below the Gemfile.

mensfeld commented 2 years ago

ah, do you want me to fix this for you?

wincent commented 2 years ago

Sure, if you have a clear idea for what to do[^i] — it may be just moving some stuff around, but we have to be careful not to break things for the 99% use case (ie. plug-in installs).

[^i]: I don't. 😬

mensfeld commented 2 years ago

Ok, let me close it in that case then. Not worth taking the risk.