search

wincohi / bookmark-notes

a firefox webextension to bring back pre-62 bookmark annotations
Mozilla Public License 2.0
23 stars 4 forks source link

Import bookmarks - File filter is *.htm and not *.html #15

Closed francwalter closed 6 years ago

francwalter commented 6 years ago

When I import a bookmarks file, which I exported from Firefox Bookmarks management, I get a default named file: bookmarks.html. But when I import that now to bookmark-notes this searches as default filter only for htm-files, so the bookmarks.html is not shown. This is not a big deal, I can set the filter to all files (.) but it is not so pretty. So please change the file filter to .html;.htm so the default file is shown. Thanks.

EDIT: by the way, bookmarks-notes does NOT import my bookmarks.html file, the 'Import' Button is not activated, even not after a while.

wincohi commented 6 years ago

That is odd, because the file input is actually set to accept "text/html" (link), so it should take both .htm and .html files. When I test on my system, I can successfully see to select the file even if I rename it to .htm, and the Import button highlights when it should.

What OS and version of Firefox are you using?

francwalter commented 6 years ago

Firefox 61, Windows 8.1 (64) I went back to FF61 because of that change with notes in bookmarks and wait till there is a adequate replacement for it which works till I update FF. Will test it in MacBook tomorrow...

ecc29 commented 6 years ago

Same issue. It doesn't work with firefox v62.02 on windows 10. The import button was always gray after file selection.

jscher2000 commented 6 years ago

It doesn't work with firefox v62.02 on windows 10. The import button was always gray after file selection.

It's gray when the pre-import parsing dies for one reason or another. As a workaround, you can convert a JSON backup to an importable HTML format file using this tool -- make sure to check the box for "Bookmark Notes importable":

https://jscher2000.github.io/Firefox-File-Utilities/bookbackreader.html

When my regular site comes back up, it also will be here: https://www.jeffersonscher.com/ffu/bookbackreader.html

wincohi commented 6 years ago

This should be fixed in 3f16676ac62e230800dbc06016fd34b60a7b7e81 in v1.1.3, just pushed to AMO.