search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Update funders and goals #100

Closed wincowgerDEV closed 2 years ago

wincowgerDEV commented 2 years ago

This PR is in response to #98 and is ready for review.

zsteinmetz commented 2 years ago

That looks awesome! I like the colors :rainbow: Just some minor comments above. Let me know what you think.

wincowgerDEV commented 2 years ago

Thanks for the review bro! I'll get these added in today and then merge and push to the web.

On Mon, Oct 11, 2021, 7:33 AM Zacharias Steinmetz @.***> wrote:

That looks awesome! I like the colors 🌈 Just some minor comments above.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/pull/100#issuecomment-940087481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU4THVPIVX5AJH4RYSDUGLYVLANCNFSM5FW36DIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zsteinmetz commented 2 years ago

I won't have much time tomorrow. But if you wait until Wednesday, I could prepare a new CRAN submission so that we have the same package version on Shinyapps and on CRAN. What do you think?

wincowgerDEV commented 2 years ago

That's a good idea. I'll wait until Wednesday to push to the web.

On Mon, Oct 11, 2021, 7:47 AM Zacharias Steinmetz @.***> wrote:

I won't have much time tomorrow. But if you wait until Wednesday, I could prepare a new CRAN submission so that we have the same package version on Shinyapps and on CRAN. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/pull/100#issuecomment-940098065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJUZZPXWF4WHUWG5FLMLUGL2IVANCNFSM5FW36DIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

wincowgerDEV commented 2 years ago

Updated all with above commit

zsteinmetz commented 2 years ago

I just had the idea of using more or less the same styling for the colored boxes as for the containers. This adds white borders with round corners and makes the background slightly transparent:

image

I find this a little more pleasing to the eye. What do you think? If you don't like it, I'll soft revert that commit.

wincowgerDEV commented 2 years ago

Hey Zacharias

That look great to me, smart idea! Let's go with that update. I'm ready to push it whenever.

Warm Regards Win

On Wed, Oct 13, 2021, 2:36 AM Zacharias Steinmetz @.***> wrote:

I just had the idea of using more or less the same styling for the colored boxes as for the containers. This adds white borders with round corners and makes the background slightly transparent:

[image: image] https://user-images.githubusercontent.com/10266826/137107590-8222d1f9-acad-47a4-8dbb-42effa644d2d.png

I find this a little more pleasing to the eye. What do you think? If you don't like it, I'll soft revert that commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/pull/100#issuecomment-942114810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJUYJ2OXSWSSRBPD6JUTUGVHLJANCNFSM5FW36DIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.