search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Cran fixes #138

Closed wincowgerDEV closed 11 months ago

wincowgerDEV commented 12 months ago

Opening this to start a discussion

wincowgerDEV commented 12 months ago

@zsteinmetz, went through and ignored some of the tests and examples that cran was upset about. Also tried to speed up the vignette.

zsteinmetz commented 11 months ago

Hey @wincowgerDEV, I already reduced the number of examples before. Let's try another submission with the remaining ones before excluding them completely. dontrun examples are often neglected because everybody thinks they're wrong by example.

wincowgerDEV commented 11 months ago

Sounds good!

zsteinmetz commented 11 months ago

I ran some additional tests. Timings look better now. Preparing 1.0.1 ...