Closed philipp-baumann closed 11 months ago
Sounds sensible to me! Yet, if you plan to submit your package to CRAN anytime soon, it might be better if we just import your package rather than forking some of your functions. This would also simplify downstream maintenance in the long run. In case submitting to CRAN is not an option for you, feel free to submit a PR here if you like your code change/improved.
I suggest you keep the copy of the function like this. I plan to submit https://github.com/spectral-cockpit/opusreader2 to CRAN only, since the heurististics used in the previous pkg is not bullet proof. But let's discuss about integrating opusreader2 😎
you may want to add Pierre Roudier, too @pierreroudier
agree about CRAN, valid point! Let's maybe discuss in person, we can also have a call since we are on the way to anyway submit opusreader2 to CRAN, and also we have some neat downstream utilities regarding workflow and metadata management. Currently, I am checking out some funding to allow me to work on it, be it either private labs or larger research collaborations. :-)
Great! Let's keep the fork then until opusreader2 is on CRAN. Let me know if I can help with anything. Should we arrange a call date via email? @wincowgerDEV would you like to join?
Great! Let's keep the fork then until opusreader2 is on CRAN. Let me know if I can help with anything. Should we arrange a call date via email? @wincowgerDEV would you like to join?
Hi @zsteinmetz and @wincowgerDEV that sounds excellent. I will email you later today and we can arrange :-) next week starting from Tuesday works well for me. Talk soon.
Would love to join! Next week Wednesday onward is best for me.
On Thu, Sep 21, 2023, 2:36 AM Philipp Baumann @.***> wrote:
Great! Let's keep the fork then until opusreader2 is on CRAN. Let me know if I can help with anything. Should we arrange a call date via email? @wincowgerDEV https://github.com/wincowgerDEV would you like to join?
Hi @zsteinmetz https://github.com/zsteinmetz and @wincowgerDEV https://github.com/wincowgerDEV that sounds excellent. I will email you later today and we can arrange :-) next week starting from Tuesday works well for me. Talk soon.
— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-package/issues/144#issuecomment-1729214082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU37TWBLEVG724E4J7TX3QDCBANCNFSM6AAAAAA45GWDVI . You are receiving this because you were mentioned.Message ID: @.***>
@philipp-baumann and @pierreroudier, got you added to the contributors now, you'll be listed on the next release.
Guidelines
Description
person(given = "Philipp", family = "Baumann", email = "info@spectral-cockpit.space", role = c("ctb"), comment = c(ORCID = "0000-0002-3194-8975")),
Problem
Proposed Solution
you can add me as ctb :-) cheers
Alternatives Considered
no