search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

[Bug]: heatmap_spec(showlegend=TRUE) #145

Closed valentinavan closed 11 months ago

valentinavan commented 11 months ago

Guidelines

Project Version

No response

Platform and OS Version

macOS 12.6.8

Existing Issues

No response

What happened?

Hi,

I was trying to show the legend within the heatmap function using showlegend=TRUE but it does not show it.

Thanks

Steps to reproduce

  1. heatmap_spec(spectral_map_p, sn = spectral_map_p$metadata$sig_noise, min_sn = 5, font = list(color = "#000000"), showlegend = TRUE, colorscale = "Blues", reversescale = TRUE, paper_bgcolor = "white")

  3. ...

Expected behavior

To show the legend

Attachments

No response

Screenshots or Videos

No response

Additional Information

No response

zsteinmetz commented 11 months ago

showlegend is currently not passed from heatmap_spec() to plotly. Should we add this feature, @wincowgerDEV?

valentinavan commented 11 months ago

Yes please, if you could also add more palettes it would be nice too. Thanks!

wincowgerDEV commented 11 months ago

I think we can add support for it as an option. I originally removed it because the legend wasn't working well with the app but I bet it could work on their now too, just never brought it back.

wincowgerDEV commented 11 months ago

Got this added to the latest PR @valentinavan. Should be up on CRAN in the next couple of weeks.