search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Various bug fixes #147

Closed wincowgerDEV closed 11 months ago

wincowgerDEV commented 11 months ago

Fixes a fatal error in match_spec() probably causing incorrect identifications. Also fixes #144 and fixes #145.

wincowgerDEV commented 11 months ago

@zsteinmetz, could we merge this one pretty soon and send it to CRAN? I discovered a fatal error in the match_spec function so people are likely getting incorrect identifications currently, and want to make sure we correct that soon. The error was causing the identities from the libraries to be scrambled. I ran the checks and there is one thing I still can't figure out, it says that an incorrect "}" is being used but I cannot find the offender.

zsteinmetz commented 11 months ago

I'll try to check the code asap and prepare a new submission.

zsteinmetz commented 11 months ago

@wincowgerDEV, have you got an email to confirm the new CRAN submission?

wincowgerDEV commented 11 months ago

@wincowgerDEV, have you got an email to confirm the new CRAN submission?

@zsteinmetz , yup, got it and accepted.