search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

[Feature]: Supporting TSV files #153

Closed wincowgerDEV closed 10 months ago

wincowgerDEV commented 10 months ago

Guidelines

Description

Wesley Williams shared this .tsv file that is provided by the instrument he uses. Isn't currently supported but probably wouldn't be too hard since the extension is unique and its a text based file format.

https://drive.google.com/file/d/16RkEX4xms1QV-FHv90Rag1szULo_j9Uv/view?usp=sharing

Problem

tsv files not currently supported.

Proposed Solution

Create a read_tsv option and add to read_any.

Alternatives Considered

require they convert using another software.

wincowgerDEV commented 10 months ago

Also may want to add this file to the ext files for testing.

zsteinmetz commented 10 months ago

The OpenSpecy package already reads .tsv files with read_text(). No need for a separate function. We just need to add the file extension to read_any().

wincowgerDEV commented 10 months ago

Oh awesome! Sounds like an easy fix.

On Fri, Oct 20, 2023, 7:39 AM Zacharias Steinmetz @.***> wrote:

The OpenSpecy package already reads .tsv files with read_text(). No need for a separate function. We just need to add the file extension to read_any().

— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-package/issues/153#issuecomment-1772865880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU22FGBXTCJLAXEFL7TYAKEKPAVCNFSM6AAAAAA6C23MLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZSHA3DKOBYGA . You are receiving this because you authored the thread.Message ID: @.***>