wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

[Feature]: Add region of interest to sig_noise #154

Closed wincowgerDEV closed 9 months ago

wincowgerDEV commented 10 months ago

Guidelines

Description

I think it could be useful to allow a user to specify where the signal is and where the noise is in the sig_noise function.

Problem

Users currently have to use a second function to fine-tune signal and noise calculations and may have to deal with some complex logic to nest them together correctly.

Proposed Solution

Add specification for signla region and one for noise region in sig_noise. This could be passed first to using restrict_range to create a dataset for just the signal and one for just the noise. If null then use the whole dataset.

Alternatives Considered

Require the logic explained in the problem.

wincowgerDEV commented 9 months ago

Fixing with https://github.com/wincowgerDEV/OpenSpecy-package/pull/157