search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Streamlining identification #157

Closed wincowgerDEV closed 9 months ago

wincowgerDEV commented 9 months ago

Right now I think identification is a little convoluted because it always requires that you use preprocessing first to conform the spectra. I want conformation to be a part of the match_spec function too. This configuration will allow us to speed up the processing routine in the app by bypassing the conformation step until we do the match. In many cases, code workflows will also be more succinct because the match_spec function can be used alone. I want to make a new test to make sure that this update conforms to the alternative routine and add this logic into the tutorials.

wincowgerDEV commented 9 months ago

Also adding fix for https://github.com/wincowgerDEV/OpenSpecy-package/issues/154

wincowgerDEV commented 9 months ago

@zsteinmetz, I am pretty happy with this PR, if you have a chance to review and sign off too, that would be great! Trying to Keep PRs relatively small and manageable so we don't end up having that monster PR like the big release one again.

zsteinmetz commented 9 months ago

Trying to Keep PRs relatively small and manageable so we don't end up having that monster PR like the big release one again.

Totally agree!

wincowgerDEV commented 9 months ago

@zsteinmetz Hope you are doing well! Just pinging you again, I got these changes implemented now in the shiny app. If we can push this update to CRAN it will allow me to more easily streamline the update there.

zsteinmetz commented 9 months ago

So sorry! It's been quite stressful lately. I'll look into it first thing next week.

wincowgerDEV commented 9 months ago

Sorry to hear you've been stressed out lately man please let me know if I can help in any way! Really appreciate you sending this through.

On Sat, Nov 25, 2023, 5:06 AM Zacharias Steinmetz @.***> wrote:

Merged #157 https://github.com/wincowgerDEV/OpenSpecy-package/pull/157 into main.

— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-package/pull/157#event-11060690349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU6FN2USMZNUM3JXVMLYGHUNVAVCNFSM6AAAAAA7BSU63OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA3DANRZGAZTIOI . You are receiving this because you authored the thread.Message ID: @.*** com>