Closed wincowgerDEV closed 3 years ago
zsteinmetz
commented
3 years ago Don't you just need to exchange this line with
bootstrapLib(bs_theme(fg = "#F9FBFA", bootswatch = "cyborg", bg = "#060606")),to make it work?
Besides, which advantage do you see over shinythemes? Don't know if it's really necessary to let the user customize the theme.
wincowgerDEV
commented
3 years ago The theme is more customizable with bslib than with shinytheme. It'll make it easy for us to update and tinker with the themes without having to write a bunch of css. The new bslib package has this cool interactive themer that we can use too.
On Fri, Mar 19, 2021, 4:57 AM Zacharias Steinmetz @.***> wrote:
Don't you just need to exchange this line with
bootstrapLib(bs_theme(fg = "#F9FBFA", bootswatch = "cyborg", bg = "#060606")),
to make it work?
Besides, which advantage do you see over shinythemes?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/issues/29#issuecomment-802782181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU5SOKPAGOQCT5NEEMDTEM34DANCNFSM4ZNP4SMA .
wincowgerDEV
commented
3 years ago I'll try out that function you suggested.
On Fri, Mar 19, 2021, 6:35 AM win cowger @.***> wrote:
The theme is more customizable with bslib than with shinytheme. It'll make it easy for us to update and tinker with the themes without having to write a bunch of css. The new bslib package has this cool interactive themer that we can use too.
On Fri, Mar 19, 2021, 4:57 AM Zacharias Steinmetz < @.***> wrote:
Don't you just need to exchange this line with
bootstrapLib(bs_theme(fg = "#F9FBFA", bootswatch = "cyborg", bg = "#060606")),
to make it work?
Besides, which advantage do you see over shinythemes?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/issues/29#issuecomment-802782181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU5SOKPAGOQCT5NEEMDTEM34DANCNFSM4ZNP4SMA .
zsteinmetz
commented
3 years ago The new bslib package has this cool interactive themer that we can use too.
That's what I wanted to switch off first :rofl: .. but the decision is yours!
wincowgerDEV
commented
3 years ago 😂! What did you want to avoid about it? I need your genius when it comes to coding stuff.
On Fri, Mar 19, 2021, 6:39 AM Zacharias Steinmetz @.***> wrote:
The new bslib package has this cool interactive themer that we can use too.
That's what I wanted to switch off first 🤣 .. but the decision is yours!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/issues/29#issuecomment-802839783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU2TGUAZNFMREKMS7SLTENHYTANCNFSM4ZNP4SMA .
zsteinmetz
commented
3 years ago I found it a little bit distracting since the focus should be on analyzing spectra and not so much on which theme to choose. This is why I would rather go with one theme (or just a toggle for dark and bright) and that's it. But I can live (and code) with anything :wink:
wincowgerDEV
commented
3 years ago Oh yeah! I don't think we should let people choose the theme,
I think we should just use the tool to figure out what theme we want to use and then choose one.
On Fri, Mar 19, 2021 at 7:14 AM Zacharias Steinmetz < @.***> wrote:
I found it a little bit distracting since the focus should be on analyzing spectra and not so much on which theme to choose. This is why I would rather go with one theme (or just a toggle for dark and bright) and that's it. But I can live (and code) with anything 😉
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/issues/29#issuecomment-802863948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU4FY3HN22AGEMLOYS3TENL5DANCNFSM4ZNP4SMA .
--
·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------Win Cowger PhD Candidate, Environmental Sciences: Soil and Water University of California, Riverside
NSF Graduate Research Fellow Research Advisor to 5 Gyres https://www.5gyres.org/advisors/ Data Advisor to Let's Do It World https://www.letsdoitworld.org/
Contact Info
515-298-3869 | @.***
Websites www.openspecy.org www.wincowger.com http://andrewgray.ucr.edu/people/wcowger.html
wincowgerDEV
commented
3 years ago Was able to move the words on the sliders over a little bit. Will keep the theme as is for now instead of messing with the bsthemer. Changed the other UI components per your suggestions. Also went ahead and changed everything to radiobuttons instead of dropdown boxes. I think the radiobuttons display the options better and the UI classes a bit with the new popups on hover with the dropdowns because it will hide the dropdown.
I tried to use the new bslib package to improve the open specy theme and ended up creating a conflict with the shinyBS package. The updated theme worked but it made the shinyBS package popups completely invisible. I can't find anything online about this issue yet. It might be worth bringing up to the Shiny team or to the bslib team.