search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Interface graph axes #49

Closed paloeffler closed 3 years ago

paloeffler commented 3 years ago

Absorbance spectra, when given in wavenumbers, are usually labeled from high (left) to low (right) numbers on the x-axis. This is to prevent misunderstandings, because a higher wavenumber means lower wavelength or frequency. In the displayed manner high wavenumber could lead to the assumption of a high wavelength or frequency.

zsteinmetz commented 3 years ago

Good point! What's your take on this @wincowgerDEV?

wincowgerDEV commented 3 years ago

@paloeffler we really appreciate the comment. I agree with you that it is more readily interpretable to have wavenumbers be ordered in the way you suggested. The whole use of wavenumbers (the number of that size of waves that could fit into a centimeter) is a strange metric but is the standard for spectroscopy. I looked into some of the other software I have and they default to the form you suggest. Let's make it happen. We can always add reversing the order back to what it is now as an advanced feature too. We will get this updated by the time we do the next CRAN push and should have the GitHub version updated in the next week or so.

@zsteinmetz looks like there are some simple ways to reverse the axes: https://plotly.com/r/axes/#reversed-axes

Warm Regards, Win

zsteinmetz commented 3 years ago

@zsteinmetz looks like there are some simple ways to reverse the axes: https://plotly.com/r/axes/#reversed-axes

Yep, shouldn't be a big deal. I can take care of it.

zsteinmetz commented 3 years ago

Note @wincowgerDEV that we'll also need to change the vignette screenshots accordingly sooner or later. I consider this fixed for now but leave the branch open for later edits.

wincowgerDEV commented 3 years ago

Good point! I'll do that once we push the update.

On Thu, Apr 1, 2021, 5:47 AM Zacharias Steinmetz @.***> wrote:

Closed #49 https://github.com/wincowgerDEV/OpenSpecy/issues/49 via #51 https://github.com/wincowgerDEV/OpenSpecy/pull/51.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy/issues/49#event-4541166503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJUZ5BEKPQVGXLZPLLPTTGRTMNANCNFSM42ENMY4A .