search

wincowgerDEV / OpenSpecy-package

Analyze, Process, Identify, and Share, Raman and (FT)IR Spectra
http://wincowger.com/OpenSpecy-package/
Creative Commons Attribution 4.0 International
23 stars 11 forks source link

Fix occasional errors on CRAN #99

Closed zsteinmetz closed 2 years ago

zsteinmetz commented 2 years ago

Skip tests on CRAN if they require an internet ressource

wincowgerDEV commented 2 years ago

I see you are way ahead of me @zsteinmetz :) well done. Going to review this and see if I can help out.

wincowgerDEV commented 2 years ago

I like your strategy of adding skip_on_cran Hopefully that will work to get the cran folks happy. I guess all the tests do are make sure that there aren't errors that we are already aware of. Assisting us in the case that we move code around and it starts performing some unexpected behaviour. I think as long as we are passing the tests internally, it doesn't really matter whether or not the CRAN also tests them. In reality, we have already created the workaround that should result in not throwing any error for the user. If there were users which were experiencing an error on startup, then we would probably hear about it too.

zsteinmetz commented 2 years ago

I like your strategy of adding skip_on_cran Hopefully that will work to get the cran folks happy. I guess all the tests do are make sure that there aren't errors that we are already aware of. Assisting us in the case that we move code around and it starts performing some unexpected behaviour. I think as long as we are passing the tests internally, it doesn't really matter whether or not the CRAN also tests them. In reality, we have already created the workaround that should result in not throwing any error for the user. If there were users which were experiencing an error on startup, then we would probably hear about it too.

Right, and the tests are still run by GitHub Actions. So we should get a good idea of whether the functions work or not before CRAN submission anyway.