search

wincowgerDEV / OpenSpecy-shiny

This is a companion repo that holds the code for www.openspecy.org website and shiny application. The Open Specy package repo https://github.com/wincowgerDEV/OpenSpecy-package
Creative Commons Attribution 4.0 International
3 stars 3 forks source link

New correlation #13

Closed wincowgerDEV closed 1 year ago

wincowgerDEV commented 2 years ago

This is a large PR, sorry! I think things are stable enough to merge it with main now but should create a previous version before doing that. Would appreciate a couple of reviewers on this.

zsteinmetz commented 2 years ago

Wow! That must have been hell of a work! This week is already quite busy, I'm afraid, but I'll look into it first thing on Monday next week.

wincowgerDEV commented 2 years ago

No rush on it at all! It's just finally stable and no one's looked at it but me yet. The next thing I want to do is to take all of these new functions we made and put them into the open specy package. I think they could be even more powerful there than on the app. But I'm expecting that to take another 6 months or something so no rush there either. Slow and steady lol.

On Mon, Jun 27, 2022, 12:20 AM Zacharias Steinmetz @.***> wrote:

Wow! That must have been hell of a work! This week is already quite busy, I'm afraid, but I'll look into it first thing on Monday next week.

— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-shiny/pull/13#issuecomment-1166978105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJUY6QHYKEFJDFPGWBITVRFI5TANCNFSM5ZZEX56A . You are receiving this because you authored the thread.Message ID: @.***>

zsteinmetz commented 2 years ago

Some questions on how to deal with the new files first:

I only took a first look into the Shiny app at runtime. Things that caught my eye (intended as a reminder to myself to look for more details/answers in the code):

wincowgerDEV commented 2 years ago

With the new framework I think we can just put the libraries in the repo so that we no longer need to pull from OSF.

The sandbox.R file is just for personal testing, I should have gitignored it! Sorry about that.

Let me know what you think.

On Wed, Jul 27, 2022 at 7:53 AM Zacharias Steinmetz < @.***> wrote:

Some questions on how to deal with the new files first:

  • are the RData files in /data intended to be there or should they be loaded from OSF upon first start?
  • is the sandbox.R file just for your personal testing or does it have a function within the repo?

— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-shiny/pull/13#issuecomment-1196864703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU43ZHP352HALN63UPTVWFEMXANCNFSM5ZZEX56A . You are receiving this because you authored the thread.Message ID: @.***>

--

´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------

Win Cowger, PhD Pronouns: he/him Research Scientist Moore Institute for Plastic Pollution Research

Contact Info

515-298-3869 | @.*** | @Win_OpenData https://twitter.com/Win_OpenData

Websites Personal Website: www.wincowger.com Currently Employed: https://mooreplasticresearch.org/ Alumni Of: https://www.thegraylab.org/ Project Websites: www.openspecy.org Research Gate: https://www.researchgate.net/profile/Win-Cowger Github: https://github.com/wincowgerDEV OSF: https://osf.io/kxeh5/

wincowgerDEV commented 2 years ago

I was able to get these things fixed today I believe:

  • [ ] Strangely, ads show in the beginning but tend to disappear for me upon longer app use.
  • [ ] I'd add some newlines between the download buttons and the 'Spectral Selection' box on the left side of the 'Analyze Spectra' tab.
zsteinmetz commented 2 years ago

I was able to get these things fixed today I believe:

  • [ ] Strangely, ads show in the beginning but tend to disappear for me upon longer app use.
  • [ ] I'd add some newlines between the download buttons and the 'Spectral Selection' box on the left side of the 'Analyze Spectra' tab.

Cool! I'll take a closer look into the code and the remaining stuff tomorrow :slightly_smiling_face:

wincowgerDEV commented 1 year ago

closing, superceeded