search

wincowgerDEV / OpenSpecy-shiny

This is a companion repo that holds the code for www.openspecy.org website and shiny application. The Open Specy package repo https://github.com/wincowgerDEV/OpenSpecy-package
Creative Commons Attribution 4.0 International
3 stars 3 forks source link

Package transfer #21

Closed zsteinmetz closed 1 year ago

zsteinmetz commented 2 years ago

This is my working copy of #13 to prepare the transfer of key functions added here to the Open Specy package repo. See https://github.com/wincowgerDEV/OpenSpecy-package/pull/117 for reference.

PR todos:

wincowgerDEV commented 2 years ago

Right on man! Thanks for helping make some headway on this. I'm hoping to get back to the code in a few weeks, for now focusing on developing a new super fast data collection routine

wincowgerDEV commented 2 years ago

Love all these steps you are proposing, wanted to check in about this one though to think through it a little more before we commit. It seems like this would essentially functionalize UI components and server components which is cool but I wonder how much reusability there is for that, like do you think that someone else will want to just have our analysis routine in their app? I see a lot of value in functionalizing the workflows in ways that people can run them in a package without opening the app at all but not totally sure how people would use the UI and server components unless they want to build another shiny app.

zsteinmetz commented 2 years ago

Love all these steps you are proposing, wanted to check in about this one though to think through it a little more before we commit. It seems like this would essentially functionalize UI components and server components which is cool but I wonder how much reusability there is for that, like do you think that someone else will want to just have our analysis routine in their app? I see a lot of value in functionalizing the workflows in ways that people can run them in a package without opening the app at all but not totally sure how people would use the UI and server components unless they want to build another shiny app.

I'd say the main advantage of this is that it'll make the code easier to maintain in the long run. So it's mainly for us. The package is more for the users, indeed, to integrate Open Specy into their workflows.

wincowgerDEV commented 2 years ago

Oh ok! Sounds good then let's do it! I made a bunch of new ui updates too btw. Shifting to bs4dash because it's extremely well featured. Going to start working on the package functions on your branch now.

On Wed, Oct 26, 2022, 4:27 PM Zacharias Steinmetz @.***> wrote:

Love all these steps you are proposing, wanted to check in about this one though to think through it a little more before we commit. It seems like this would essentially functionalize UI components and server components which is cool but I wonder how much reusability there is for that, like do you think that someone else will want to just have our analysis routine in their app? I see a lot of value in functionalizing the workflows in ways that people can run them in a package without opening the app at all but not totally sure how people would use the UI and server components unless they want to build another shiny app.

I'd say the main advantage of this is that it'll make the code easier to maintain in the long run. So it's mainly for us. The package is more for the users, indeed, to integrate Open Specy into their workflows.

— Reply to this email directly, view it on GitHub https://github.com/wincowgerDEV/OpenSpecy-shiny/pull/21#issuecomment-1292137226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU6E4LN4TRKPKOSEVETWFE5TPANCNFSM6AAAAAAQW3QF3U . You are receiving this because you commented.Message ID: @.***>

wincowgerDEV commented 1 year ago

This is my working copy of #13 to prepare the transfer of key functions added here to the Open Specy package repo. See wincowgerDEV/OpenSpecy-package#117 for reference.

PR todos:

  • [x] Move new functions to the Open Specy package
  • [ ] Update Shiny folder structure (https://shiny.rstudio.com/articles/modules.html)
  • [ ] Revisit config.yml approach; for instance to make ads disappear on a local installation
  • [ ] Check package dependencies

I think we will save the modules for a future release, they can be challenging to maintain from people I have talked to about them. I will go through the config and package dependencies before I merge.

wincowgerDEV commented 1 year ago

Closing, superceeded