wind-project / wind

WiND is a Web application for managing a database of wireless nodes.
GNU Affero General Public License v3.0
33 stars 31 forks source link

nodesettingschanges #53

Closed stargazerwna closed 10 years ago

stargazerwna commented 10 years ago

test nodesettingschanges

sque commented 10 years ago

stargazer, nice to see making pull requests :) First of all, what is this pull request for? What does exactly changes? Is there any relevant issue that i fixes?

Ysam, plz stop merging! We agreed to do it two persons for the sake of code consistency... I don't like enforcement policies (user permissions) so please respect this. You bypass code reviews...

ysamouhos commented 10 years ago

Doing the changes myself.

sque commented 10 years ago

This is very nice of you, but I think stargazer is a very capable programmer to know how to make these changes. He should also be given the opportunity to question the code reviews. Maybe he has something better to propose.

ysamouhos commented 10 years ago

For sure. On next commit he will, now that he knows.

stargazerwna commented 10 years ago

@sque https://github.com/wind-project/wind/issues/47

@ysamouhos Thank you :)

acinonyx commented 10 years ago

http://en.wikipedia.org/wiki/Good_cop/bad_cop

ysamouhos commented 10 years ago

:)

jbonicioli commented 10 years ago

Cops are not always involved lol http://en.wikipedia.org/wiki/Bipolar_disorder

stargazerwna commented 10 years ago

...

Λεωνίδας Παπαδόπουλος

Sent from my iPad

28 Μαϊ 2014, 12:18, ο/η jbonicioli notifications@github.com έγραψε:

Cops are not always involved lol http://en.wikipedia.org/wiki/Bipolar_disorder

— Reply to this email directly or view it on GitHubhttps://github.com/wind-project/wind/pull/53#issuecomment-44382557 .