search

wind-python / windpowerlib

The windpowerlib is a library to model the output of wind turbines and farms.
https://oemof.org/
MIT License
330 stars 105 forks source link

Add module for data handling and check integrity of turbine data #101

Closed uvchik closed 4 years ago

uvchik commented 4 years ago
  1. Add function to check the integrity of the turbine data base. This could help to avoid #100 in the future.
  2. Restructure the data handling and move all related functions into the new data module.

UPDATE:

  1. get_turbine_types() will not silently import new database from oedb. In the past the local data has been overwritten by this function.
uvchik commented 4 years ago

There are still some tests missing with a wrong dataset.

At the moment the test will log suspicious data sets but will not remove them. If the check leads to an error the data set will not be stored. This could be changed in the future, so that only broken datasets are remove but the rest will be stored.

It is possible to add additional checks.

@birgits, @SabineHaas Please check whether you agree with the basic approach.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging d32aca5a23a9c9bab3c7b8d8d9ecb3c7e4899013 into 1273dea0fcbd4722bc96bbce4921a5c517879d01 - view on LGTM.com

new alerts:

birgits commented 4 years ago

Thank you @uvchik! I only had a quick look so far and made some minor comments. As far as I can see without running the code myself, it looks good. If you want a more thorough feedback it unfortunately has to wait until after my holidays.

uvchik commented 4 years ago

A new thought about this issue. We could store the update of the turbine data at a new place. This will have some advantages: