wind-python / windpowerlib

The windpowerlib is a library to model the output of wind turbines and farms.
https://oemof.org/
MIT License
326 stars 105 forks source link

WindTurbineCluster takes only WindFarms but not WindTurbines #70

Open uvchik opened 5 years ago

uvchik commented 5 years ago

The input of the WindTurbineCluster is a list of WindFarm objects. WindTurbine objects are not allowed. I think we should either rename the class or allow WindTurbine objects or both.

uvchik commented 5 years ago

What about WindFarmCluster?

SabineHaas commented 4 years ago

decision dev meeting: Allow WindTurbines / WindTurbineGroups in WindTurbineCluster.

uvchik commented 4 years ago

I have two ideas how to deal with the problem.

  1. We could convert all WindTurbines to WindFarms with just one Turbine. This is not very elegant but in my opinion the easiest way.
  2. We could make sure that all WindTurbines or WindTurbineGroups do have the same attributes needed in the cluster class and its methods. At some place we may have to distinguish between types. I think this is the better solution because we do not have to copy the object.
SabineHaas commented 4 years ago

At the last dev meeting I promised to provide information for the second suggestion in your last comment. Here it is:

This "in-between" step of getting the aggregated wind farm power curves instead of just aggregating all wind turbine power curves (of all wind farms) was implemented like that to give the option of applying wake losses to wind farm power curves (of which each could have e.g. a different wind farm efficiency).

Options I see now to make WindTurbines possible in WindTurbineClusters.:

  1. Give WindTurbine the method assign_power_curve() which is just returning the power curve
  2. Differentiate here between WindTurbines and WindFarms

Other things I noticed: